Project

General

Profile

Actions

Defect #3014

closed

Use new version of asciidoctor-maven-plugin

Added by Roman Kučera over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roman Kučera
Category:
Documentation
Target version:
Start date:
12/07/2021
Due date:
% Done:

100%

Estimated time:

Description

Build of .war will fail on this error
Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.3:process-asciidoc (output-html) on project idm-example: Execution output-html of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.3:process-asciidoc failed.: NullPointerException -> [Help 1]

This error can occur on rpt-impl module, example or vs.

This behavior was tested on multiple PCs.
This error occur even with clean Git repo and empty local maven repo

Build works previously, because there was probably "the right" dependecy cached in local .m2 but for people, who want to build now will fail.

Actions #1

Updated by Roman Kučera over 2 years ago

  • Status changed from New to Needs feedback
  • % Done changed from 0 to 80

In all product .pom I used version 2.2.1 which is the newest.
I checked the official migration guide https://docs.asciidoctor.org/maven-tools/latest/plugin/v2-migration-guide/ no changes are needed
I briefly compared the doc from previous .war and from new .war and it looks same. I compared core impl modul idm-app-12.0.0.war\WEB-INF\lib\idm-core-impl-12.0.0.jar\META-INF\resources\webjars\core\12.0.0\doc\index.html

Commit is in develop.
Github action is OK

@doischert could you please provide me a feedback

Actions #2

Updated by Roman Kučera over 2 years ago

I tested the final .war it runs correctly
Swagger docs which is accessible from IdM work correctly to.

Actions #3

Updated by Tomáš Doischer over 2 years ago

LGTM, I tried to build the war using idm-tool and everything was fine. It wasn't working before. Thank you for the fix!

Actions #4

Updated by Roman Kučera over 2 years ago

  • Tracker changed from Task to Defect
  • Affected versions 10.8.0, 10.8.1, 10.8.3, 11.0.0, 11.1.0, 11.1.2, 11.1.1, 11.2.0, 11.2.1, 11.2.2, 11.2.3, 12.0.0 added
Actions #5

Updated by Roman Kučera over 2 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 80 to 100

Released

Actions

Also available in: Atom PDF