Task #2914
closed
Multivalued attributes comparison highlight.
Added by Ondrej Husník over 3 years ago.
Updated over 3 years ago.
Description
The goal is to implement a suitable way how to highlight individual values of a multivalued attribute comparison result. It will be useful when displayed on the provisioning detail and will also be part of the task Differential report #2880
Files
- Related to Task #2880: Differential report IdM added
- Status changed from New to In Progress
- % Done changed from 0 to 70
Majority of the functionality is implemented.
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
- % Done changed from 70 to 90
I refactored existing code and moved the previous implementation of the detailed comparison of changed account attribute values from VS into ACC module. It will be used in linked task #2880 and is also used on the provisioning detail to highlight changed attributes and type of the change. The used approach is the same as in case of difference comparison on the VS request detail.
Please could you do a feedback for me?
https://github.com/bcvsolutions/CzechIdMng/commit/9db53b7d05a781e944680b898b5b441598b4716e
I did reivew. Nice UX feature. I appreciate the courage to abstract and move logic from VS to ACC.
I found few problems during testing:
- LdapGroup value is not showing up in the current column.
- It also displays 'undefined' values.
- A strange condition where the localization key is missing. At the same time, the original value should not have 'null' in it.
- ProvisioningOperations.153 -> add check on null (const itemValue = item && item.value ? item.value : '';)
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
- Category set to UX
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondrej Husník
- % Done changed from 80 to 100
I tested it again. All my scenarios works well now. Thanks for this.
- Status changed from Resolved to Closed
Also available in: Atom
PDF