Project

General

Profile

Actions
Copy link

Task #2914

closed

Multivalued attributes comparison highlight.

Added by Ondrej Husník over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondrej Husník
Category:
UX
Target version:
11.2.0
Start date:
08/24/2021
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The goal is to implement a suitable way how to highlight individual values of a multivalued attribute comparison result. It will be useful when displayed on the provisioning detail and will also be part of the task Differential report #2880

Files

Download all files
diff_missing_loc_key_values.png (444 KB) diff_missing_loc_key_values.png Vít Švanda, 09/03/2021 09:33 AM
diff_ldapGroups_missing_undefined.png (434 KB) diff_ldapGroups_missing_undefined.png Vít Švanda, 09/03/2021 09:33 AM

Related issues

Related to IdStory Identity Manager - Task #2880: Differential report IdMClosedRadek Tomiška07/09/2021

Actions
Actions
Copy link
 #1

Updated by Ondrej Husník over 2 years ago

  • Related to Task #2880: Differential report IdM added
Actions
Copy link
 #2

Updated by Ondrej Husník over 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 70

Majority of the functionality is implemented.

Actions
Copy link
 #3

Updated by Ondrej Husník over 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda
  • % Done changed from 70 to 90

I refactored existing code and moved the previous implementation of the detailed comparison of changed account attribute values from VS into ACC module. It will be used in linked task #2880 and is also used on the provisioning detail to highlight changed attributes and type of the change. The used approach is the same as in case of difference comparison on the VS request detail.
Please could you do a feedback for me?

https://github.com/bcvsolutions/CzechIdMng/commit/9db53b7d05a781e944680b898b5b441598b4716e

Actions
Copy link
 #4

Updated by Vít Švanda over 2 years ago

I did reivew. Nice UX feature. I appreciate the courage to abstract and move logic from VS to ACC.

I found few problems during testing:

  • LdapGroup value is not showing up in the current column.
  • It also displays 'undefined' values.
  • A strange condition where the localization key is missing. At the same time, the original value should not have 'null' in it.
  • ProvisioningOperations.153 -> add check on null (const itemValue = item && item.value ? item.value : '';)
Actions
Copy link
 #5

Updated by Ondrej Husník over 2 years ago

  • Status changed from In Progress to Needs feedback

I implemented fixes which should prevent from occurring problems you found. Could you please try it once again? I was not able to simulate all possible scenarios which you found. Thank you.

https://github.com/bcvsolutions/CzechIdMng/commit/cc3fb76e8273865043588c31fe0d74988866bb2b

Actions
Copy link
 #6

Updated by Ondrej Husník over 2 years ago

  • Assignee changed from Ondrej Husník to Vít Švanda
Actions
Copy link
 #7

Updated by Vít Švanda over 2 years ago

  • Category set to UX
  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondrej Husník
  • % Done changed from 80 to 100

I tested it again. All my scenarios works well now. Thanks for this.

Actions
Copy link
 #8

Updated by Ondrej Husník over 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF