Project

General

Profile

Actions

Defect #2813

closed

If automatic role creating is controlled by WF approving process, its rejection causes script failure

Added by Ondrej Husník almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondrej Husník
Category:
Workflow
Target version:
Start date:
05/14/2021
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Automatic role creation can be controlled by 'approve-role-by-guarantee-security' WF if proper criticality is set. Then when solver disapproves this task, an exception is thrown during the execution of the following WF scriptTask17.

2021-05-14 16:27:15.939  WARN 375335 --- [http-nio-8080-exec-11] o.a.e.i.b.b.ScriptTaskActivityBehavior.execute : Exception while executing scripttask17 : problem evaluating script: javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: conceptRole for class: Script6
2021-05-14 16:27:15.952 ERROR 375348 --- [http-nio-8080-exec-11] o.a.e.i.interceptor.CommandContext.logException : Error while closing command context
org.activiti.engine.ActivitiException: problem evaluating script: javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: conceptRole for class: Script6
    at org.activiti.engine.impl.scripting.ScriptingEngines.evaluate(ScriptingEngines.java:89)
    at org.activiti.engine.impl.scripting.ScriptingEngines.evaluate(ScriptingEngines.java:73)
    at org.activiti.engine.impl.bpmn.behavior.ScriptTaskActivityBehavior.execute(ScriptTaskActivityBehavior.java:76)
    at org.activiti.engine.impl.agenda.ContinueProcessOperation.executeActivityBehavior(ContinueProcessOperation.java:180)
    at org.activiti.engine.impl.agenda.ContinueProcessOperation.executeSynchronous(ContinueProcessOperation.java:131)
    at org.activiti.engine.impl.agenda.ContinueProcessOperation.continueThroughFlowNode(ContinueProcessOperation.java:89)
    at org.activiti.engine.impl.agenda.ContinueProcessOperation.run(ContinueProcessOperation.java:55)
Actions #1

Updated by Vít Švanda almost 3 years ago

  • Assignee changed from Vít Švanda to Ondrej Husník
  • Target version set to 11.1.0
Actions #2

Updated by Ondrej Husník almost 3 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Ondrej Husník almost 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda
  • % Done changed from 0 to 90

The script task canceling automatic role change request after the change is disapproved was wrong. Now there is used the right one.
Please, could you provide me a feedback.

https://github.com/bcvsolutions/CzechIdMng/commit/938855ca80fb343014556b9a23d86cb7e39ecf88

Actions #4

Updated by Vít Švanda almost 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondrej Husník
Actions #5

Updated by Ondrej Husník almost 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda

Added also tests for creating automatic roles using the approve-role-by-guarantee-security workflow.
Please feedback also this.
https://github.com/bcvsolutions/CzechIdMng/commit/58738260d998bce99d2d7a40ec19746de87f39b5

Actions #6

Updated by Vít Švanda almost 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondrej Husník
  • % Done changed from 90 to 100

I did reivew. Thanks for nice tests for approve and disapprove UC.

Actions #7

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF