Project

General

Profile

Actions
Copy link

Feature #2669

closed

Add rejection reason to approval task

Added by Vladimír Kotýnek about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Ondrej Husník
Category:
Workflow
Target version:
11.1.0
Start date:
01/29/2021
Due date:
% Done:

100%

Estimated time:
40.00 h
Owner:

Description

Please add rejection reason to role approval tasks.
When the approver disapprove role assignment he/she should be able to fill reason of the dissapprovement. In IDM configuration this field might be set as mandatory.

Actions
Copy link
 #2

Updated by Vladimír Kotýnek about 3 years ago

  • Priority changed from Normal to High
  • Target version set to 11.1.0
Actions
Copy link
 #4

Updated by Vít Švanda almost 3 years ago

  • Assignee changed from Vít Švanda to Ondrej Husník
Actions
Copy link
 #5

Updated by Ondrej Husník almost 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Ondrej Husník almost 3 years ago

  • % Done changed from 0 to 60
Actions
Copy link
 #7

Updated by Ondrej Husník almost 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda
  • % Done changed from 60 to 90

Workflow tasks were extended by possibility of inserting the decision reason or solver's note. It can be enforced as mandatory. Original task was little generalized and the reason can be added to all decision types, not only the rejection. After product presentation I modified original approach and reused already existing item ''taskCompleteMessage''.
Usage and configuration is described in doc:
https://wiki.czechidm.com/devel/documentation/workflows/dev/workflow?s[]=%2Aworkflow%2A#setting_solver_note_message_-_decision_reason

Please could you provide me the feedback.
https://github.com/bcvsolutions/CzechIdMng/commit/c7b04829f9bff341ebd4ce8af2f6183fcb7f9430

Actions
Copy link
 #8

Updated by Vít Švanda almost 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondrej Husník
  • % Done changed from 90 to 100

I did review and tested it. Works awesome, thanks for that.

Review notes:
  • DynamicTaskDetail:122 "this.setState({reasonRequired: decision.reasonRequired});". Please call rest of block as callback in setState method. (Maybe "reasonRequired" may not be a state.)
  • Only "approve" and "reject" variants are now supported in the application configuration. This can be done more dynamically with any decision button name (in connfiguration key). This is not important because user can now modify a WF definition for it.
  • Please modify wiki documentation as we told.
Actions
Copy link
 #9

Updated by Ondrej Husník almost 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda

Thank you for your feedback and remarks.
I improved the FE code and extended doc.
https://github.com/bcvsolutions/CzechIdMng/commit/7debc6003616f675180e1cfbbe59565922f6ec5c
https://wiki.czechidm.com/devel/documentation/workflows/dev/workflow?s[]=%2Aworkflow%2A#setting_solver_note_message_-_decision_reason

The dynamic composition of properties is a good idea. Thanks for it. I guess it could be extended this way in a future task in case of need.

Actions
Copy link
 #10

Updated by Vít Švanda almost 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondrej Husník

I made rereview, thnaks for that.

Actions
Copy link
 #11

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF