Feature #2664
closed
Bulk add and remove contract manager
Added by Vladimír Kotýnek over 3 years ago.
Updated about 3 years ago.
Description
Create two new bulk actions on Identities.
1) Bulk add new direct manager to identity contracts
- Select identities
- Select bulk action
- Select identity to be set as a direct manager - only valid identity can be selected
- run
The bulk action will add this identity as a direct manager to all contracts if not already set.
2) Bulk remove direct manager from identity contracts
- select identities
- select bulk action
- select identity to be removed from direct managers - both valid and disabled identities can be selected
- run
The bulk action will remove this identity from direct managers of all contracts of selected identities.
Possible third LRT will replace direct manager.
3) Bulk replace direct manager
- select identities
- select bulk action
- select identity of existing direct manager you want to replace - "original manager"
- select identity of new direct manager you want to set - only valid identity can be selected - "new manager"
- run
The bulk action will check if the selected identity has the "original manager" set as direct manager of any contract. If so it removes the direct manager and sets "new manager" as direct manager. Otherwise it skips the contract and do nothing with it's managers. So if the identity didn't have the "original manager" set as a direct manager before the bulk action the "new manager" will not be set as it's direct manager.
- Assignee changed from Radek Tomiška to Ondrej Husník
- Target version set to 10.8.0
- Target version changed from 10.8.0 to 11.0.0
- Due date set to 02/23/2021
- Status changed from New to In Progress
- Target version changed from 11.0.0 to 10.8.0
- Priority changed from Normal to High
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
- % Done changed from 0 to 80
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 80 to 90
I did test and code review, it works, thx! I like permission usage, bulk action icons are nice!
Review notes:
- I used update method to change guarantee (=> provisioning olny once, better message in action logs, the same behavior as from FE)
- I removed logs for identities, which are iterated only
- I removed required IDENTITY_COUNT permission - it's not needed for this actions
- I added ContractGuaranteeInfo component - visible in logs (add, update)
- parameter converter can be used for get bulk action properties
- toString is called automatically in logs
- improved positions for icons (missing padding in bulk action detail)
- we don't use abrevations
- we are using camelCase
Commits:
https://github.com/bcvsolutions/CzechIdMng/commit/3313393bb0b1d4de312709e6b1a65091ed558e8d
https://github.com/bcvsolutions/CzechIdMng/commit/e044ccc04cca9a5e9d2f5ca20aea25d753138d41
Could you please provide me feedback (and test) after my changes?
Thank you for feedback and for your improvements. Especially added business card for contract guarantee improved UX.
- Status changed from Needs feedback to Resolved
- % Done changed from 90 to 100
- Status changed from Resolved to Closed
- Related to Defect #2990: Some bulk actions started by managers process more users/contracts than they should added
Also available in: Atom
PDF
