Project

General

Profile

Actions
Copy link

Task #2622

closed

FE: upgrade gulp - use version 4

Added by Radek Tomiška over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Architecture
Target version:
11.0.0
Start date:
12/18/2020
Due date:
% Done:

100%

Estimated time:
80.00 h
Owner:

Related issues

Related to IdStory Identity Manager - Feature #2621: FE: Support images from custom moduleNewRadek Tomiška12/18/2020

Actions
Related to IdStory Identity Manager - Feature #2059: Check maximum height and width uploaded profile pictureClosedRadek Tomiška02/14/2020

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška over 3 years ago

  • Related to Feature #2621: FE: Support images from custom module added
Actions
Copy link
 #2

Updated by Radek Tomiška over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Radek Tomiška over 3 years ago

  • Status changed from In Progress to New
Actions
Copy link
 #4

Updated by Radek Tomiška over 3 years ago

  • Category changed from Infrastructure to Architecture
Actions
Copy link
 #5

Updated by Radek Tomiška about 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Radek Tomiška about 3 years ago

  • Status changed from In Progress to New
Actions
Copy link
 #7

Updated by Radek Tomiška about 3 years ago

  • Target version changed from 10.8.0 to 11.0.0
Actions
Copy link
 #8

Updated by Vít Švanda about 3 years ago

  • Estimated time set to 80.00 h
Actions
Copy link
 #9

Updated by Radek Tomiška about 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #10

Updated by Radek Tomiška about 3 years ago

  • % Done changed from 0 to 50

Gulp is upgraded, remaining issues:
- linter dont work properly in other than app module
- tests don't work
- source code changes on locales are not watched properly

Actions
Copy link
 #11

Updated by Radek Tomiška about 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 50 to 90

Frontend libraries are upgraded, Gulp 4 is used for build now. Production source codes are fully compatible, the only change is needed in linter configuration file (''.eslintrc'') for analyzing javascrict source codes in custom modules (but module can be build even without this change).

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/905e4c0835551ce746be8d65cbf06aa452b86033

Doc:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/CHANGELOG.md#developer

Could you provide me a feedback, please?

Actions
Copy link
 #12

Updated by Vít Švanda about 3 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and tested it. Works awesome. I'm glad for new gulp and for reduce vulnerabilities.

I had problems with linter in IDEA. I had to copied babel.config.json to every module. Now it works in IDEA properly. I modied changelog too.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/cef2ad111b99d7666f4db834eb9b4e1f28a1bd7e

Actions
Copy link
 #13

Updated by Radek Tomiška about 3 years ago

  • Status changed from Needs feedback to Resolved
Actions
Copy link
 #14

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #15

Updated by Radek Tomiška almost 3 years ago

  • Related to Feature #2059: Check maximum height and width uploaded profile picture added
Actions
Copy link

Also available in: Atom PDF