Project

General

Profile

Actions

Task #2505

closed

Don't import synchronization token when importing a system (exclusion of fields)

Added by Alena Peterová about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Export Import
Target version:
Start date:
09/25/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Version 10.4.6
When importing a system, the synchronization token is imported together with the whole system.
This is dangerous - you can import older or newer token (e.g. from test do production) and you wouldn't notice it.

Actions #1

Updated by Vít Švanda about 4 years ago

What is the goal here?
  • First: A token will cleared after each import.
  • Second: A token should be excluded from export/import (old value will be unchanged on the target IdM).

First is trivial, second is much more complex new feature.

Actions #2

Updated by Vít Švanda about 4 years ago

  • Status changed from New to In Progress
  • Target version set to 10.6.0
Actions #3

Updated by Alena Peterová about 4 years ago

Vít Švanda wrote:

What is the goal here?
  • First: A token will cleared after every import.
  • Second: A token should be excluded from export/import (old value will be unchanged on target IdM).

The second - the token should be excluded. The reason is that if we clear it or import a different token, then the next synchronization processes different records than what is expected.

Actions #4

Updated by Vít Švanda about 4 years ago

I suspected that the second option would win :-) .

Actions #5

Updated by Alena Peterová about 4 years ago

Sorry :-)
I think there are more fields that could be somehow excluded - e.g. creator, modifier etc. Because now you can see a lot of "changes" when you run import (or dry run), but a lot of them are not important.

Actions #6

Updated by Vít Švanda about 4 years ago

I agree. Here is good to note, that content of DTO is not compare the during the import. So each existed DTO if is exactly same as target will be logged as updated. I will like to implement comparing on the field level, but this is different story (feature).

Actions #7

Updated by Vít Švanda about 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 90

Feature for exclude fields in a import implemented.
Now is uses for exclude the token field from export of a system.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/c330653e57574bdd8e4f3c22950ff012a128dfb4
Doc updated: https://wiki.czechidm.com/devel/documentation/adm/export_import

Actions #8

Updated by Vít Švanda about 4 years ago

  • Subject changed from Don't import synchronization token when importing a system to Don't import synchronization token when importing a system (exclusion of fields)
Actions #9

Updated by Radek Tomiška about 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

I did test and code review, it works and code looks nice, thx!

Actions #10

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF