Task #2494
closedSystem - automatic creation of mapped attributes (for common identity schema attributes)
100%
Updated by Vít Švanda over 4 years ago
- Subject changed from System - automatic creation of mapped attributes (for common schema attributes) to System - automatic creation of mapped attributes (for common identity schema attributes)
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 0 to 90
I made first version of generating an mapped attributes by schema attributes.
It is realize by processor (SystemMappingIdentityAutoAttributesProcessor) on create system-mapping. Implemented are only basic fields from a identity.
This processor is used only if event contains enable property. This is necessary for ensure backward compatibility (because VS and tests).
Tests were created too.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/8f4755fe3432ee931ab771b03495467165897f58
Updated by Radek Tomiška about 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 80
This feature is awesome, I did test and code review.
I found some issues:
- seccurity is missing in overriden SysSystemMappingController#post and SysSystemMappingController#postDto can be overriden instead (benefit - less code + just event propagation without response)
Some notes only (can be implemented optionally):
- SysSystemMappingService#ENABLE_AUTOMATIC_CREATION_OF_MAPPING - 'core:' or 'idm:' prefix and format can be used (see EntityEvent properties).
- name catalogues can be moved to static string array constants in processor (e.g CATALOGUE_PHONE = new String{"phone", "mobile" ...}) - it will be visible at the first sight (configuration is not necessary i hope so, but this catalogue will be improved in future after project feedback maybe).
Updated by Vít Švanda about 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 80 to 90
I made some improvements (you have a good eye on the security issues):
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/7180266b0c008f9244bc5c68583ec9f37d04b571
Updated by Radek Tomiška about 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
I did test and review again, it's awesome, thx!
Updated by Radek Tomiška about 4 years ago
- Status changed from Resolved to Closed