Project

General

Custom queries

Profile

Actions

Task #2482

closed

Notification: add entity for attachments

Added by Radek Tomiška over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
Start date:
09/11/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Notification attachment is supported, but is not logged / persisted into database:
- add NotificationAttachment entity / dto / service / rest
- add attachment table to notification detail
- update report test in #2074 to check attachments are included


Related issues

Related to IdStory Identity Manager - Feature #2074: Schedule a report and send itClosedRadek Tomiška02/19/2020

Actions
Actions #1

Updated by Radek Tomiška over 4 years ago

Actions #2

Updated by Radek Tomiška over 4 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

Feature is implemented - attachments are logged now and can be downloaded from notification agenda.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/2eb06f25b4284726cf1282934f1e38b7997d8376

Doc:
https://wiki.czechidm.com/devel/documentation/notifications/dev/notification_manager#notification_and_attachments

Could you provide me a feedback, please?

Actions #4

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška

I did reivew and test. Nice feature thanks for that. I found one problem. If one notification log is deleted then all notification attachments are deleted.

Actions #5

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

This issue with delete all notification attachments was really dangerous, thx for good feedback!

Fixed in commit:
https://github.com/bcvsolutions/CzechIdMng/commit/c1102214b5aa59fa27203e022d03adc1322d5b54

Could you provide me a feedback again, please?

Actions #6

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and tested it. Works well. LGTM

Actions #7

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF