Project

General

Profile

Actions
Copy link

Feature #2479

closed

FE: fixed bottom buttons in modal window

Added by Radek Tomiška over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
10.6.0
Start date:
09/10/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Add affix for b modal window footer => modal buttons will be on screen, when modal is too long.

Related issues

Related to IdStory Identity Manager - Feature #2374: Improve design of the role catalog modalClosedRadek Tomiška07/07/2020

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška over 4 years ago

  • Subject changed from FE: fixed button for modal window to FE: fixed bottom buttons in modal window
Actions
Copy link
 #2

Updated by Radek Tomiška over 4 years ago

  • Tracker changed from Task to Feature
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

Feature is implemented. When modal window in longer than screen height, then modal footer is affixed on bottom. The single modal footer is required to be used in modal window to enable this feature.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/988100c488cabcb70150d6f7b2c9a4859bfb6ced

Could you provide me a feedback, please?

Note: Resize window event is not fully supported now.

Actions
Copy link
 #3

Updated by Radek Tomiška over 4 years ago

  • Related to Feature #2374: Improve design of the role catalog modal added
Actions
Copy link
 #4

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 50
Actions
Copy link
 #5

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 50 to 90

I fixed issues with window resize event, dynamic modal body changes, scrolling on inner components (e.q. textarea in modal) and wrong z-index:
https://github.com/bcvsolutions/CzechIdMng/commit/fd3153ead05539d6cc9cc4da2bb0d9785c762687

Could you provide me a feedback, please?

Note: I had to add new npm library to support dynamic modal body changes.

Actions
Copy link
 #6

Updated by Radek Tomiška over 4 years ago

Actions
Copy link
 #7

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did reivew and tested it. This is awesome UX feature thanks for that.

Actions
Copy link
 #8

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF