Project

General

Profile

Actions
Copy link

Task #2458

closed

Test: Refactor module Acc to impl + test-api

Added by Radek Tomiška over 3 years ago. Updated over 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Vít Švanda
Category:
Infrastructure
Target version:
10.6.0
Start date:
08/27/2020
Due date:
% Done:

90%

Estimated time:
Owner:

Description

Test classes have to be copied from Acc module into custom module (TestHelper, TestResource etc.), when custom module needs to provide integration test using acc module (see Report module).

Create new acc-test-api module - this dependency will be used instead copying whole test sources from Acc module (the same mechanism as core-test-api).

This change ineeds to be propageted into IdMtool + doc.

Actions
Copy link
 #1

Updated by Radek Tomiška over 3 years ago

  • Description updated (diff)
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

Module Acc refoctored to api, impl, test-api.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/9bc1e680234785b706fb5e40036009276946dbd6

Could you provide me a feedback, please?

Actions
Copy link
 #2

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to Rejected

I did review. This was a only solution how prevent copying tests utility to project modules. But I think the change of the ACC module structure (separate to 3 modules) is maybe overkill with respect to the goal (prevent copying of tests utilities).

For reason backwards compatibilitiy, I want to let the ACC module without this change.

Actions
Copy link

Also available in: Atom PDF