Feature #2398
closed
When copying default virtual system, multivalued attribute 'rights' is not created as multivalued in its form definition
100%
Description
When you create a default virtual system, one multivalued attribute 'rights' is created. When you then make a copy of the system, the attribute is created as multivalued in the system scheme but it is not created in the system form definition at all (single valued attributes are created, though). If you then go and change the system (maybe name, maybe state) and save it, the attribute is created but not as multivalued.
This can potentially lead to an error when this attribute is used. If you have two roles, each connects to this copy of the virtual system and each fills different values into it, you will get a server error when you try to accept the request.
Related issues
Updated by Tomáš Doischer over 3 years ago
This was tested in 9.7.16 and 10.4.2, it happens in both.
Updated by Vít Švanda over 3 years ago
- Target version set to 10.6.0
The system duplication operation provides a copy of all configurations from the system in the ACC module only.
The problem is that the "rights" attribute is attached to the VsAccount object and is part of the VS module. This is why this attribute is not duplicated.
The solution is to implement system duplication through multiple modules (ACC and VS).
This is a new feature for 2MD.
Updated by Vít Švanda over 3 years ago
- Tracker changed from Defect to Feature
- Assignee changed from Vít Švanda to Ondrej Husník
- Target version changed from 10.6.0 to 10.7.0
Updated by Radek Tomiška over 3 years ago
- Has duplicate Feature #2550: Export+import of a virtual system - empty additional attributes in virtual requests, error when using the "rights" attribute added
Updated by Radek Tomiška over 3 years ago
- Has duplicate deleted (Feature #2550: Export+import of a virtual system - empty additional attributes in virtual requests, error when using the "rights" attribute)
Updated by Radek Tomiška over 3 years ago
- Related to Feature #2550: Export+import of a virtual system - empty additional attributes in virtual requests, error when using the "rights" attribute added
Updated by Vít Švanda over 3 years ago
- Target version changed from 10.7.0 to 10.8.0
Updated by Tomáš Doischer over 3 years ago
This is also true for system export and import. If you have a virtual system with a multivalued attribute and try to export it, after importing it again the form definition does not have this attribute set to multivalued (it is still multivalued in the scheme).
Updated by Vít Švanda about 3 years ago
- Target version changed from 10.8.0 to 11.0.0
Updated by Vít Švanda about 3 years ago
- Assignee changed from Ondrej Husník to Vít Švanda
Updated by Vít Švanda about 3 years ago
- Assignee changed from Vít Švanda to Ondrej Husník
- Estimated time changed from 24.00 h to 32.00 h
Updated by Vít Švanda about 3 years ago
@husniko You mentioned that you want to learn more about virtual systems. This is a good chance for you :-).
Updated by Ondrej Husník about 3 years ago
- Status changed from New to In Progress
Updated by Ondrej Husník about 3 years ago
- % Done changed from 0 to 80
This feature extends ability of being copied to virtual systems. VS duplication code is put into the new created processor responsible for VS specific duplication implementation.
Please, could you test this feature and provide me a feedback. Thanks.
https://github.com/bcvsolutions/CzechIdMng/commit/bc428f1970a67e7465be42cec52c81670d7fe2bc
Updated by Ondrej Husník about 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
Updated by Vít Švanda almost 3 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Ondrej Husník
I did review and tested it. Works awesome, thanks for that.
I found only minor thinks:- System processors should have an interface for better searching.
- Services on your processors should be marked as private.
Updated by Ondrej Husník almost 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
Thank you for the feedback. Interface for system processors has been added and missing field modifiers too.
Please review changes for me.
https://github.com/bcvsolutions/CzechIdMng/commit/748449c606ca6d92981c433828722d7497dbd0bf
Updated by Vít Švanda almost 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondrej Husník
- % Done changed from 80 to 100
LGTM
Updated by Radek Tomiška almost 3 years ago
- Status changed from Resolved to Closed