Project

General

Profile

Actions
Copy link

Defect #2387

closed

Wrong Exception messages format in SSO authentication filter

Added by Vladimír Kotýnek over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
2.5.0
Start date:
07/14/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
2.4.0
Owner:

Description

In ExtrasSsoIdmAuthenticationFilter.java there are several lines with wrong formating Exception messages like this one:

throw new IdmAuthenticationException(MessageFormat.format("Attribute with code [{}] not found", fieldName));

Calling this method ends up with error

Forwarding to error page from request [/index.html] due to exception [can't parse argument number: ]

Please fix this bug.

Actions
Copy link
 #1

Updated by Vladimír Kotýnek over 4 years ago

  • Assignee set to Peter Štrunc
Actions
Copy link
 #2

Updated by Marek Klement over 4 years ago

  • Assignee changed from Peter Štrunc to Marek Klement
Actions
Copy link
 #3

Updated by Marek Klement over 4 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Marek Klement to Peter Štrunc
  • % Done changed from 0 to 90
  • Fixed exception by adding
    [{0}]
  • Added test for exceptions messages.
  • On branch personal/klement/2392-improve-logging-and-security
  • Tests have 82% coverage.
Actions
Copy link
 #4

Updated by Peter Štrunc over 4 years ago

  • Status changed from Needs feedback to Closed
  • Target version set to 2.5.0
  • % Done changed from 90 to 100
  • Affected versions 2.4.0 added

It looks great. Thanks

Actions
Copy link

Also available in: Atom PDF