Task #2386
closed
Transform old repository filter for system attribute mapping to authorizable service for support get predicates method and filters that can be overriden and added by service or new filter
100%
Description
Remove old filter usage for service SysSystemAttributeMappingService. Now the service use old behavior with repository filter. Transform whole behavior to toPredicates method into JPA criteria.
Related issues
Updated by Ondřej Kopr over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
- % Done changed from 10 to 90
Methods from repository SysSystemAttributeMappingRepository was marked as deprecated. Service SysSystemAttributeMappingService implement AuthorizableService now and new permissions was added for system attribute mapping. Now is available Create, Read, Update and Delete - frontend components was updated. Tests are included.
I have only one issue with method SysSystemAttributeMappingService#findBySystemMapping, method calls method in repository findAllBySystemMapping_Id. But the original method for null parameter return empty list. Our filter returns for null parameter all records. This was solved by if statement
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/cb696de9e2f8f527eba3702c5a19435b3c704cc9
Please Vitek could you provide me a feedback? Thank you.
Updated by Radek Tomiška over 4 years ago
- Related to Task #799: Systems - add authorization policies support added
Updated by Radek Tomiška over 4 years ago
I removed new group permission till system agenda will fully support authorization policies #799.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/4e2b86674b071640e99646a8076f0980b7e75f85
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondřej Kopr
- % Done changed from 90 to 100
I did review and test. LGTM
Updated by Radek Tomiška over 4 years ago
- Status changed from Resolved to Closed