Project

General

Profile

Actions

Defect #2385

closed

Audit of role requests - cannot filter by date, approvers are not displayed

Added by Alena Peterová over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Roles
Target version:
Start date:
07/13/2020
Due date:
% Done:

90%

Estimated time:
Affected versions:
Owner:

Description

Version 10.4.1
Audit -> Requests for roles
When filter by Date is selected, the page returns an error "Filter for attribute [face] not found."

Also, the column "Can solve" is always empty in this table, even if there are approvers of the task (which is visible on the task detail). There are 2 places:
Dashboard of the logged user:

Audit of Role requests:


Files

filter_by_date.png (38.3 KB) filter_by_date.png Alena Peterová, 07/13/2020 04:50 PM
audit_requests.png (25.2 KB) audit_requests.png Alena Peterová, 07/13/2020 04:53 PM
can_solve_request_detail.png (20.2 KB) can_solve_request_detail.png Alena Peterová, 07/13/2020 04:53 PM
user_dashboard.png (20.6 KB) user_dashboard.png Alena Peterová, 07/13/2020 04:54 PM
role-request-can-solved.png (53.6 KB) role-request-can-solved.png Vít Švanda, 07/14/2020 12:03 PM

Related issues

Related to IdStory Identity Manager - Task #2282: Filter: Throw exception, when no registered filter is foundClosedRadek Tomiška05/29/2020

Actions
Actions #1

Updated by Vít Švanda over 4 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to 10.5.0
Actions #2

Updated by Vít Švanda over 4 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Vít Švanda over 4 years ago

Exception withing filtering by date component is caused by face property (TODAY for example) sending to BE. For this property doesn't exist filter and filter checker throw exception.

I will remove face property form filter query (is not uses now).

But better solutions for you now is turn off this filter checker:

idm.sec.core.filter.check.supported.enabled=false

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/64066728077cef932aa2fbce804fa91cb789e501

Actions #4

Updated by Vít Švanda over 4 years ago

Second problem with empty column "Can solve":

It works for me, solvers are shown. But I maybe know where is you problem. I think your request isn't approve by main WF process, but by some subprocess. By default, the column on request table shown approvers for main process only. Approvers are show on the request detail, because extra feature for show all approvers includes subprocess too was implemented here. Reason why, aren't all approvers show in table too, is performance (query can be very expensive here). I know, this is confused for user (I spent long time with debuging it today too).

Actions #5

Updated by Alena Peterová over 4 years ago

  • Assignee changed from Alena Peterová to Vít Švanda

You are right, this was a subprocess for a role with criticality 2. There were no other types of requests in this project.
I understand it's for performance reasons and it can't solved for now.
Maybe you could add some additional info to the column header? So nobody else will lose their time trying to understand, why it's empty, as we did? :-) My main concern is the dashboard, which is the place where I noticed it first when I was logged as a common user.

Actions #6

Updated by Alena Peterová over 4 years ago

Alena Peterová wrote:

Maybe you could add some additional info to the column header? So nobody else will lose their time trying to understand, why it's empty, as we did? :-) My main concern is the dashboard, which is the place where I noticed it first when I was logged as a common user.

Or put there clickable "..." and after clicking, it will load the approvers from the subprocesses for the specific request, as it is on the task request detail. That would be nice :-)

Actions #7

Updated by Vít Švanda over 4 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 90
Actions #8

Updated by Radek Tomiška over 4 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
  • Affected versions 10.4.0, 10.4.1 added

I skipped validation for 'face' attribute on BE. The previous solution does not save filled filter in redux.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/b0ce69de704fdeee1fab11d444d64b4d7040d269

Could you provide me a feedback, please?

Actions #9

Updated by Radek Tomiška over 4 years ago

  • Related to Task #2282: Filter: Throw exception, when no registered filter is found added
Actions #10

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Radek Tomiška

I did review and tested it. Thanks for this fix.

Actions

Also available in: Atom PDF