Project

General

Profile

Actions
Copy link

Defect #2383

closed

After approving the task, a new notification is sent about the same task

Added by Alena Peterová over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Notification
Target version:
10.5.0
Start date:
07/13/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
10.4.0, 10.4.1
Owner:

Description

Version: 10.4, 10.4.1

When approvers approve the task, they are notified again about assigning a task. But it's the same task they already approved.

Tested on project with different approval workflows for different priorities, and also on product. The extra notification is sent for all priorities.

  • Enable notifications about the creation of an approval task:
    idm.sec.core.wf.notification.send=true
  • Create a role with criticality 2 and some approver (jnovak)
  • Assign the role to somebody
  • Approve the role by the approver
  • Check notifications - there is a notification corresponding to the time of approving the workflow


Files

Download all files
role.png (38.9 KB) role.png Alena Peterová, 07/13/2020 09:23 AM
wf_task_assigned.png (31.8 KB) wf_task_assigned.png Alena Peterová, 07/13/2020 09:30 AM
notifications.png (44.8 KB) notifications.png Alena Peterová, 07/13/2020 09:30 AM
wf_task_created.png (31.5 KB) wf_task_created.png Alena Peterová, 07/13/2020 09:30 AM
task.png (9.08 KB) task.png Alena Peterová, 07/13/2020 09:30 AM

Related issues

Related to IdStory Identity Manager - Feature #984: Delegations in IdMClosedVít Švanda02/26/2018

Actions
Actions
Copy link
 #2

Updated by Alena Peterová over 4 years ago

  • Category changed from Roles to Notification
  • Assignee changed from Radek Tomiška to Vít Švanda

Note: It's somehow connected to 10.4; these notifications worked well in 10.3.3.

Actions
Copy link
 #3

Updated by Vít Švanda over 4 years ago

  • Status changed from New to In Progress
  • Target version set to 10.5.0
Actions
Copy link
 #4

Updated by Alena Peterová over 4 years ago

Simple workaround for our use case: deactivate the notification topic core:wfTaskAssigned.

Actions
Copy link
 #5

Updated by Vít Švanda over 4 years ago

  • % Done changed from 0 to 50

I tested this on version 10.3.1 and is it true. The assigne notification is not send in this version.

I found a cause. Problem were in versions previouse the version 10.4.0. Assigne notification should be sent, but there was a bug. The recipient for this notification was searching by username, but wf-task contains UUID in assignee.

Within implementation of delegations I fixed this bug and this is the reason why is notification sending now.

Assigne field is filled after a wf-task is completed and is uses as indicator for who completed this task. This cause why is this notification send after completed a task.

I suggest remove this notification / topic from next version, because I don't see good reason for this notification.

Actions
Copy link
 #6

Updated by Vít Švanda over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 50 to 90

I removed listener and sending notification on ASSIGNEE_TASK event.

Topic stays for compatibility reason.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/8ba2c10cab86ceb3be2361b12ff58d33845395bc

Actions
Copy link
 #7

Updated by Radek Tomiška over 4 years ago

Actions
Copy link
 #8

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100
  • Affected versions 10.4.0, 10.4.1 added

I did test and code review, notification is sent only once now, thx!

Actions
Copy link

Also available in: Atom PDF