IdStory IdM modules » extras

New LRT was created, because the old LRT was really reusable and it was easier to create new one. The old is still there, and we can discuss to mark it as deprecated and remove it in some next version for example.

• check max length for new automatic role name , now is only DefaultFieldLengths.NAME,
• method taskNotCompleted is not used, you can delete this method,
• task catches errors but without returning correct resultOperation, please return specific result operation for failed task,
• (optional) some configuration properties are required and missing default values. You can setup default values for these configurations for each IdmFormAttributeDto,
• for extras version 2.5.0 is possible translate long running task name and parameters please do it :-P.

In processed items are rules not automatic roles, is this correct?

The current review is for me OK. I leave task opened because after some consultation on presentation is possible that you will made some changes :).

I checked little performance test for one role with 500 rules and your taks creates 500 rules in 12 second. I dont recommended automatic role with 500 rules because recalculation for one role takes more than 10 minutes.

Ondřej Kopr wrote:

I just made review. Whole functionality works :) there is just some minor things:

• check max length for new automatic role name , now is only DefaultFieldLengths.NAME,
• method taskNotCompleted is not used, you can delete this method,
• task catches errors but without returning correct resultOperation, please return specific result operation for failed task,
• (optional) some configuration properties are required and missing default values. You can setup default values for these configurations for each IdmFormAttributeDto,
• for extras version 2.5.0 is possible translate long running task name and parameters please do it :-P.

In processed items are rules not automatic roles, is this correct?

The current review is for me OK. I leave task opened because after some consultation on presentation is possible that you will made some changes :).

I checked little performance test for one role with 500 rules and your taks creates 500 rules in 12 second. I dont recommended automatic role with 500 rules because recalculation for one role takes more than 10 minutes.

Thx, I fixed all issues in https://github.com/bcvsolutions/czechidm-extras/commit/d0ebb1b7b4bc2aac4a4029ce26584c3fe2237aad
About logging rules into processed items, this behavior is intended, because I think that it's useful to see on FE how many rules where imported. I just fixed the number of processed items so it won't display for example 7/3 but correctly 7/7

Fixed test https://github.com/bcvsolutions/czechidm-extras/commit/a2fcc334115c1fede823bd2f8fd7918bbe39aeaf

Right now I am doing some more refactoring based on our internal discussion. Some abstract LRT class will used

Hey @kucerar,
how is it going with the refactoring? Could you please look at this merge request https://github.com/bcvsolutions/czechidm-extras/pull/38 and confirm that it contains everything needed?

Thanks

@sourek I checked the MR a it looks good to me, all commits should be there.
After you merge it into develop, I will just test the LRT quickly to see if everything works correctly, because @doischert makes some changes in the abstract class.

Added changes from #2390 into develop branch. cherry pick was unusable so I moved the changes manually.
I retest this LRT on develop with the new changes and and it works as intended.
Behavior is same as in LTS version #2390
commit https://github.com/bcvsolutions/czechidm-extras/commit/7505c4898f830868339d48f822e56a5d55489be6