Task #2272
closed
Add a filter to find managers' contracts by subordinate's contract
100%
Description
It is similar as searching of managers for identity (identityService.findAllManagers(identityId)).
Updated by Vít Švanda over 4 years ago
- Subject changed from Add filter for find manager's contracts by subordinate's contract to Add a filter to find managers' contracts by subordinate's contract
Updated by Radek Tomiška over 4 years ago
- Status changed from New to In Progress
Updated by Radek Tomiška over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 0 to 90
I've added new filters for contracts. The filters has the same behavior as filters for identities, but I didn't change these filters - additional join is needed for contracts and this join is not needed for identities. The second benefit is backward compatibility.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/f4da911a0729f7efbcb57b98dbe5804493fc3a6e
Doc:
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#defaultmanagercontractbysubordinatecontractfilter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#guaranteecontractbysubordinatecontractfilter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#eavcodemanagercontractbysubordinatecontractfilter
Could you provide me a feedback, please?
Note: The names of filters are toooooo long - i tried to be more descriptive in this case. I can rename it, if you will have some idea.
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
I did review and test. Its very hard to read it for me, because these filters are very complex. Name convention is clear and confused in same time, but I don't have better idea.
I tested this mainly in delegation and I was surprised with using filter.isIncludeGuarantees() in filter. I thinked my using in delegation was wrong, because I do not set includeGuarantees to true here, but after some testing and debug is see that property is set by default on true, so it is correct.
Thanks for this feature.
Updated by Radek Tomiška over 4 years ago
- Status changed from Resolved to Closed