IdStory IdM modules » extras

I checked the code and tried the feature, it works great.

As for the code, on line 472 there is

long count = roleSystemService.count(roleSystemFilter, null);

the null is not needed there (it shows warning for me).

Please update the documentation: replace the screenshot and maybe add the new column to the detail of the data at the beginning of the tutorial. Also, there is a "warning" in the documentation "This LRT can be used to update existing values but it does not remove old values. The only overwritten values during update are role criticality and description.". Since this feature works in the same way as description, it should be mentioned there.

Otherwise, it's great. Thank you.

It looks good. @kucerar could you please refactor

if(hasMemberOf) {
                String transformationScript;
                if (hasMemberOfValue) {
                    transformationScript = MessageFormat.format("\"{0}\"", memberOfValues.get(roleName));
                } else {
                    transformationScript = MessageFormat.format("\"{0}\"", roleName);
                }
                roleSystemAttributeService.addRoleMappingAttribute(system.getId(), role.getId(), memberOfAttribute, transformationScript, OBJECT_CLASSNAME);

this block of code, which is used twice, into one method? Then i will merge it to develop. Thanks