Project

General

Profile

Actions
Copy link

Task #2258

closed

Implement support for sync of role-catalogue

Added by Vít Švanda almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondrej Husník
Category:
Synchronization
Target version:
10.6.0
Start date:
05/15/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Related issues

Related to IdStory Identity Manager - Task #520: Support synchronization of role catalogsRejected06/20/2017

Actions
Actions
Copy link
 #1

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.4.0 to 10.6.0
Actions
Copy link
 #2

Updated by Vít Švanda over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Vít Švanda over 3 years ago

  • Estimated time set to 24.00 h
Actions
Copy link
 #4

Updated by Radek Tomiška over 3 years ago

  • Related to Task #520: Support synchronization of role catalogs added
Actions
Copy link
 #5

Updated by Ondrej Husník over 3 years ago

  • % Done changed from 0 to 70
Actions
Copy link
 #6

Updated by Ondrej Husník over 3 years ago

  • Assignee changed from Ondrej Husník to Vít Švanda
  • % Done changed from 70 to 90

I implemented role catalogue synchronization. It originates from general tree node synchronization.
Please could you provide me a feedback?

https://github.com/bcvsolutions/CzechIdMng/commit/9291e72987b623a7e35f187b4cae7bb4dea9dccd
https://wiki.czechidm.com/devel/documentation/synchronization/dev/role-catalogue-sync

Actions
Copy link
 #7

Updated by Vít Švanda over 3 years ago

  • Status changed from In Progress to Needs feedback
Actions
Copy link
 #8

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondrej Husník

I did reivew and tested it. Works nice. Thanks for that.

I found some minor issues:

Actions
Copy link
 #9

Updated by Ondrej Husník over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Vít Švanda

Thank you for your review. According your findings I added missing reference to documentation and changed variable name in order to better fit the content. I also extracted the TreeResultsHandler class into individual file.

Please check my changes again.
https://github.com/bcvsolutions/CzechIdMng/commit/f6197f9b86020b4e83b36884c2b4a3efd46f085d
https://wiki.czechidm.com/devel/documentation/synchronization/dev/synchronization#entities_that_supports_sync

Actions
Copy link
 #10

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondrej Husník
  • % Done changed from 90 to 100

I did rereview. LGTM

Actions
Copy link
 #11

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF