Project

General

Profile

Actions
Copy link

Task #2255

closed

Codelist: clean redux state after code list is changed.

Added by Radek Tomiška almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
CodeList
Target version:
10.6.0
Start date:
05/14/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Clean redux state after code list is changed (codelist code or items) to enforce codelists are refreshed on FE.

E.g. When new codelist item is added, then new item is shown after and application is refreshed by F5.

Actions
Copy link
 #1

Updated by Radek Tomiška almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Radek Tomiška over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Radek Tomiška over 3 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to 10.6.0
  • % Done changed from 0 to 90

Feature is implemented. Code list is reload after item is created, changed or deleted too. When whole code list is deleted, then reload is called too.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/1f6b23b7566ad98b58d0d275a658d9d6bd01ff79

Could you provide me a feedback, please?

Actions
Copy link
 #4

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška

I did reivew and tested it. Works well. After I tested it, I tried previous behavior on the demo (10.2.0). Change of codelist items works well there. I added new or changed existed item and change was propageted without F5, what I do not understand?

One note: I was supprised that localized name of item (if exists) is not displayed in the item table. I thought it was broken in this ticket, but this was never implemented (but could be :-) ).

Actions
Copy link
 #5

Updated by Radek Tomiška over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

Thx for feedback! I've added missing localization into codelist item table:

https://github.com/bcvsolutions/CzechIdMng/commit/7ecdd7c8f3866c812bd86296f84490ee17eed73d

Colud you provide me a feedback again, please?

Note: The issue was with CodeListValue component used in tables. CodeListSelect loaded codelist from BE every time, so I improved this behavior too, when this redux state is cleared now.

Actions
Copy link
 #6

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

Thanks for the localization. LGTM

Actions
Copy link
 #7

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF