Feature #2240
closed
Evaluator for all roles in one role catalogue
100%
Description
Goal of this ticket is create new evaluator for roles in one role catalogue (including sub catalogues).
Updated by Ondřej Kopr almost 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
I moved the evaluator from project to extras and not is moved from extras to product.
Documentation:- https://wiki.czechidm.com/devel/documentation/security/dev/authorization#rolebyrolecatalogueevaluator
- https://wiki.czechidm.com/devel/documentation/security/dev/authorization/role_evaluator_by_role_catalogue
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/1902782671acd896010467455c644394f13d332c
Branch: okopr/2240-evaluator-for-roles-in-catalogue
Merge: https://github.com/bcvsolutions/CzechIdMng/pull/111
Please Radek could provide me a feedback? Thank you :)
Updated by Radek Tomiška almost 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 80
Thx for this feature! I did test and code review, it works and code is nice, awesome!
Review notes:
- additional loading of role catalogue should be removed from both evaluator methods. Uuid is needed only and if catalogue not exists, then simply nothing is found.
- #getPermissions - IdmRoleService#count method should be used instead #find method (it will be quicker). Test is missing for this method (e.g. https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/backend/core/core-impl/src/test/java/eu/bcvsolutions/idm/core/security/evaluator/identity/IdentityByFormProjectionEvaluatorIntegrationTest.java#L84).
I just renamed evaluator by product conventions:
https://github.com/bcvsolutions/CzechIdMng/commit/0861f710377d55709586b1ce1a59fa33a7bd09bc
Updated by Ondřej Kopr almost 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 80 to 90
Thank you for feedback. The changes will be also moved into extras module.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/1bc627d29cbd42d10c0e657638bae845b5db3f10 (same branch)
Please Radek could you check the branch again? Thanks :)
Updated by Radek Tomiška almost 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
It's awesome, thx!
Updated by Radek Tomiška almost 4 years ago
- Status changed from Resolved to Closed