Project

General

Profile

Task #2238

Show statistics (count) for important DB tables in IdM GUI.

Added by Vít Švanda 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Monitoring
Target version:
Start date:
05/06/2020
Due date:
% Done:

100%

Estimated time:

History

#1 Updated by Vít Švanda 5 months ago

  • Status changed from New to In Progress

#2 Updated by Vít Švanda 5 months ago

  • Category changed from Database to Monitoring
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 90

I implemented first simple version of monitoring (without DB storage). This is first version supports get a count of importent tables a show state of all active syncs.
Count is showing for these tables now: IdentityRole, RoleRequest, HistWorkflowProcess (I had to implemented count for this service), EntityState, EntityEvent, ProvisioningOperation, ProvisioningArchive, VsRequest, VsAccount.

Tests are implemented too.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/31733eee76e2b460f569d22879167a3f119c0308

#3 Updated by Vít Švanda 5 months ago

I removed some warning issues (I reconfigured my Netbeans).

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/c013dfd9f464ef51df0cd5ad415391676e08c1f1

#4 Updated by Radek Tomiška 4 months ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Vít Švanda

I did test and code review, thx for this new feature.

Review notes:
- I'm not sure about concept of monitoring types versus registrable processors. Type should be provided now in product and then some processors can be registered. Maybe some new registrable object for monitoring can be created as type and then processors can be used the same way as now.
- NotificationLevel could be used instead new MonitoringLevel enumeration. NotificationLevel is used in all other places, i know the name should be better but it's too late :)
- BE: annotations (@Beta) are placed before javadoc, somethimes is javadoc in the middle of annotations (e.g. IdmConfigurationController#getMonitoringType)
- BE: IdmMonitoringTypeDto - @Relation should be camelCase
- BE: new package for monitoring processor can be created (i expect a lot of this processors in future :))

Just info notes:
- BE: threshold is not configurable now - monitoring type (or processor) configuration can be used in future
- FE: localization for eavs (~monitoring types and configuration) can be used in future
- FE: Module column could be moved as 2nd column in table (right after state), to be the same as on other places. State column can have statis width (e.g. 25px).

#5 Updated by Vít Švanda 4 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • In the final version, the types of monitoring will definitely be dynamic.
  • Good idea with NotificationLevel enum, I use it instead MonitoringLevel now, but only on BE, because on FE I need different localization and icons.
  • IdmMonitoringTypeDto - @Relation is CamelCase now.
  • I want to delete @Beta annotations in final version and this was reason why I placed it above the javaDoc, but I moved them under it (only for you).

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/f0f22c221802d45795195406129687c930293d19

#6 Updated by Radek Tomiška 4 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

#7 Updated by Radek Tomiška 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top