Project

General

Profile

Feature #2228

Evaluator for all identites that has contract on one organization unit

Added by Ondřej Kopr 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
04/17/2020
Due date:
% Done:

100%

Estimated time:
Milestones:

Description

Goal of this ticket is create evaluator for identities that has at least one contract on specific organizational structure (including sub organizations).

Create all requirements in: https://wiki.czechidm.com/devel/documentation/modules_extras#developing_and_releasing


Related issues

Copied from extras - Task #2217: Evaluator for all identites that has contract on one organization unitClosed04/17/2020

History

#1 Updated by Ondřej Kopr 7 months ago

  • Copied from Task #2217: Evaluator for all identites that has contract on one organization unit added

#2 Updated by Peter Štrunc 7 months ago

  • Project changed from extras to CzechIdM
  • Target version deleted (2.2.0)

#3 Updated by Ondřej Kopr 7 months ago

  • Tracker changed from Task to Feature
  • Category set to 44
  • Status changed from New to In Progress
  • Target version set to 10.3.0

#4 Updated by Ondřej Kopr 7 months ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 0 to 90

I moved the evaluator from project to extras and not is moved from extras to product :)

Documentation:

Please Radek could provide me a feedback? Thank you :)

#5 Updated by Radek Tomiška 7 months ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška

#6 Updated by Radek Tomiška 7 months ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 80

Thx for this feature! I did test and code review, code is awesome!

Review notes:
- tree type is missing in predicate, so if more tree types are defined, then evalutor adds access to identity with different type by same forest index structure. Add predidace to clausule (e.g. https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/backend/core/core-impl/src/main/java/eu/bcvsolutions/idm/core/model/service/impl/DefaultIdmIdentityService.java#L208)
- additional loading of tree node should be removed from both evaluator methods. Uuid is needed only and if node not exists, then simply nothing is found.
- #getPermissions - IdmIdentityService#count method should be used instead #find method (it will be quicker).

I just renamed evaluator by product conventions:
https://github.com/bcvsolutions/CzechIdMng/commit/56d2d8c82d176ae6b9c58b391a74791ffd395e9d

#7 Updated by Ondřej Kopr 7 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 80 to 90

Thank you for review Radek. The issue with different tree type I change also in extras module in old version. Because when this happens the result may be catastrophic.

There is my changes: https://github.com/bcvsolutions/CzechIdMng/commit/2fa3e7c14d819e39cca5349704927181ffd3100c (same branch)

Thank you for feedback :)

All changes will be also moved to extras module. Please could you check the branch again?

#8 Updated by Radek Tomiška 7 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

It's awesome, thx!

#9 Updated by Radek Tomiška 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top