Project

General

Profile

Actions
Copy link

Task #2209

closed

Improve logging - don't log SEVERE when there is no error

Added by Alena Peterová over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roman Kučera
Target version:
version 1.0.5
Start date:
04/15/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The connector always logs a SEVERE line, even if there is no error:

Apr 15, 2020 6:05:00 PM net.tirasa.connid.bundles.cmd.methods.CmdExec waitFor(CmdExec.java:127)
SEVERE: Script error:

I think this should be logged as an error only if it the error output isn't empty.
CmdExec.java, method waitFor:
LOG.error("Script error:\n{0}", error);

Actions
Copy link
 #1

Updated by Roman Kučera over 4 years ago

  • Target version set to version 1.0.5
Actions
Copy link
 #2

Updated by Roman Kučera over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Roman Kučera
Actions
Copy link
 #3

Updated by Roman Kučera over 4 years ago

  • % Done changed from 0 to 80

Implemented https://github.com/bcvsolutions/winrm-ad-connector/tree/2209-dont-log-severe-without-error
Now this message is only logged if there is something to log.
Log file be less confusing now.

Actions
Copy link
 #4

Updated by Roman Kučera over 4 years ago

  • % Done changed from 80 to 90

I test it on local env and its working as intended

Actions
Copy link
 #5

Updated by Tomáš Doischer about 4 years ago

Code review done, looks good.

Actions
Copy link
 #6

Updated by Roman Kučera about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

released

Actions
Copy link

Also available in: Atom PDF