Project

General

Profile

Actions
Copy link

Task #2200

closed

Automatic filling of the name attribute when creating new automatic role.

Added by Ondrej Husník about 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Ondrej Husník
Category:
UX
Target version:
11.0.0
Start date:
04/08/2020
Due date:
% Done:

100%

Estimated time:
1.00 h
Owner:
Actions
Copy link
 #1

Updated by Ondrej Husník about 4 years ago

Name of the original role will be used.

Actions
Copy link
 #2

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.3.0 to 10.4.0
Actions
Copy link
 #3

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.4.0 to 10.6.0
Actions
Copy link
 #4

Updated by Vít Švanda over 3 years ago

  • Target version changed from 10.6.0 to 10.7.0
Actions
Copy link
 #5

Updated by Vít Švanda over 3 years ago

  • Target version changed from 10.7.0 to 10.8.0
Actions
Copy link
 #6

Updated by Vít Švanda about 3 years ago

  • Target version changed from 10.8.0 to 11.0.0
Actions
Copy link
 #7

Updated by Radek Tomiška about 3 years ago

  • Estimated time set to 1.00 h
Actions
Copy link
 #8

Updated by Ondrej Husník about 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90
Actions
Copy link
 #9

Updated by Ondrej Husník about 3 years ago

  • Assignee changed from Ondrej Husník to Radek Tomiška

If the name of automatic role is empty it is now filled with the name of the role which set as automatic.
please, could you provide me feedback.

https://github.com/bcvsolutions/CzechIdMng/commit/c48f74496a2910ffc28b147dd162619818e2e50c

P.S. commit also contains cleaned BE warnings left there from the previous task... sorry for that

Actions
Copy link
 #10

Updated by Ondrej Husník about 3 years ago

  • Status changed from In Progress to Needs feedback
Actions
Copy link
 #11

Updated by Radek Tomiška about 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondrej Husník

I did test and code review, it basically works, nice!
It works, when the name is empty only (~ for the first role selection). Expected behaivor - name is set (or changed), when name is empty or name equals previously selected role. The same behavior is already implemented in CodeableField component used e.g on role detail (when code is changed).

Actions
Copy link
 #12

Updated by Ondrej Husník about 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška

Refactored in order to act as suggested in CodeableField.
Please could you check it again.

https://github.com/bcvsolutions/CzechIdMng/commit/ffe0e8056cb90712e400d5b2fc00463a41cb56cf

Actions
Copy link
 #13

Updated by Radek Tomiška about 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 90 to 100

I did test and code review. UC above works, thx!

Actions
Copy link
 #14

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF