Project

General

Profile

Actions
Copy link

Defect #219

closed

EnumSelecBox duplicity options

Added by Ondřej Kopr about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Beryl
Start date:
11/30/2016
Due date:
% Done:

100%

Estimated time:
8.00 h
Affected versions:
Owner:

Description

  • Fix fill options values into enumSelectBox (found where is mistake),
  • add complete test for this component.
Actions
Copy link
 #1

Updated by Ondřej Kopr about 8 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Ondřej Kopr about 8 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90
Found problem:
  • valueKey in component EnumSelectBox was ITEM_FULL_KEY, but this key isn't in enum class,
  • was added ITEM_VALUE whitch is unique,
  • tested on change password form and roles detail.
EDIT:
  • after create test i was edit my solutions, because ITEM_FULL_KEY is necessary for identification options.

Test for this component.

Actions
Copy link
 #3

Updated by Radek Tomiška about 8 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #4

Updated by Ondřej Kopr about 8 years ago

After some consultation with RT.

  • EnumSelectBox now using Select.Async, this is unnecessarily. Create task for simplification this component, #229
  • for now create next if else statement block with enumeration.
Actions
Copy link
 #5

Updated by Ondřej Kopr about 8 years ago

To method itemRenderer add if statement when exists niceLabel then dont change it.

Please do test:
  • On role detail found <Basic.EnumSelectBox> line 149, remove readOnly={!Utils.Entity.isNew(entity)} and add multiSelect, then test on role detail.

Thank you.

Actions
Copy link
 #6

Updated by Ondřej Kopr about 8 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #7

Updated by Ondřej Kopr about 8 years ago

Add temporary solution, change valueKey from ITEM_FULL_KEY to ITEM_VALUE.

Actions
Copy link
 #8

Updated by Radek Tomiška about 8 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

It works, thx.

Actions
Copy link
 #9

Updated by Radek Tomiška over 5 years ago

  • Tracker changed from Task to Defect
  • Category changed from 20 to Frontend
Actions
Copy link

Also available in: Atom PDF