Task #2171
closed
General report to export tables: auto bulk action registration for all formable entites.
100%
Description
IdmIdentityGeneralEntityExport, IdmRoleGeneralEntityExport, SysSystemGeneralEntityExport were added to support export tables into csv. Remove this components and register feature dynamically for all formable entites by default (e.g. can be disabled by application (bulk action) configuration).
Related issues
Updated by Radek Tomiška over 4 years ago
- Related to Task #2069: General report to export tables to csv added
Updated by Vít Švanda over 4 years ago
- Assignee changed from Radek Tomiška to Vít Švanda
Updated by Vít Švanda over 4 years ago
Implemented.
I do not generate beans for every entity type, but I created one universal GeneralEntityExport and this bulk action will be available for all formable entities (with bulk action supports).
Main solution was in modification of the "supports" method. That bulk action is supports for every formable entity.
Classes IdmIdentityGeneralEntityExport, IdmRoleGeneralEntityExport, SysSystemGeneralEntityExport were deleted.
All changes are in branche "pstrunc/2069"
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/b77dd39a5227526d2ae1a2af4e88ce56df0e8a3f
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 0 to 70
I did test and code review, i've found one issue with security - exports ara available without authority is needed, because action is always 'null' on row GeneralEntityExport#100. I've changed this to return 'APP_ADMIN' instead, because is already in develop (sorry for merge it to early) => so normal user without 'APP_ADMIN' doesn't see report now. Could you check and fix this issue please?
Other review notes:
- GeneralEntityExport - AuthorizableService#getAuthorizableType() method could return null (e.g. DefaultIdmConceptRoleRequestService#getAuthorizableType()) - i've added check for null pointer.
- GeneralEntityExport#lookupService - added private modifier.
- GeneralEntityExport#getService() - removed generated LOG - added final static.
All notes are implemented in commit:
https://github.com/bcvsolutions/CzechIdMng/commit/d9504c85011047f10697df1d5cc39250ab92cd35
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 70 to 90
You have right, getAvailableActions returned actions in every situtation. That method worked with singleton beans and there was no way how to set entity class to generic action.
I redesigned that and new bean is created in getAvailableActions too. For performance reason I creates new bean instance only for this new action (new property isGeneric was added to AbstractBulkAction for it).
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/c2e4ab1758ed03f96fa55870cfc23f4a2832c220
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
It works, thx!
Note:
New public methods added to AbstractBulkAction should be in API (IdmBulkAction), but manager doesn't work with this API anyway.
Updated by Vít Švanda over 4 years ago
I added new method to the interface:
https://github.com/bcvsolutions/CzechIdMng/commit/d76e27c5af7ec61e86a2ca70446d89f6df7d2ab3
Updated by Radek Tomiška over 4 years ago
- Status changed from Resolved to Closed