Project

General

Profile

Task #2162

Bulk action - change user type (projection)

Added by Radek Tomiška 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Bulk operations
Target version:
Start date:
03/30/2020
Due date:
% Done:

100%

Estimated time:
Milestones:

Description

Add bulk action for change identity form projection.


Related issues

Related to CzechIdM - Task #2105: Dynamic form for identitiesClosed03/09/2020

History

#1 Updated by Radek Tomiška 8 months ago

  • Related to Task #2105: Dynamic form for identities added

#2 Updated by Vít Švanda 8 months ago

  • Assignee changed from Radek Tomiška to Ondrej Husník

#3 Updated by Ondrej Husník 7 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60

#4 Updated by Ondrej Husník 7 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 60 to 90

There was added bulk action support of the user type (projection) change to Identity agenda.
Please would you provide me a feedback?? Thank you in advance.

https://github.com/bcvsolutions/CzechIdMng/commit/1bfe09564b821b286bc6bc359ce0577c87b263d1

#5 Updated by Radek Tomiška 7 months ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondrej Husník

I did test and code review, it works, thx! I like new icon registered for identity projection.

Review notes:
- remove catching exception in gettin configured user type - it's dangerous to return null => it will remove configured projection to all selected identities. DtoUtils can be used.
- Objects#equals can be used instead comparing previous and new projection manually.

I did just cosmetic small changes:
https://github.com/bcvsolutions/CzechIdMng/commit/001cd73ba405b1a756032b6e43520e23170388c6

#6 Updated by Ondrej Husník 7 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška

Thank you for your feedback. I improved task according your findings. Also test had to be changed.
Please find some time for the final check.

https://github.com/bcvsolutions/CzechIdMng/commit/32a7a92962fd47516d20aa5fc0ed6306cb532647

#7 Updated by Radek Tomiška 7 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 90 to 100

It's awesome, thx!

#8 Updated by Radek Tomiška 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top