Project

General

Profile

Feature #2156

Redirect to historic workflow task when is already solved

Added by Ondřej Kopr 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Workflow
Target version:
Start date:
03/27/2020
Due date:
% Done:

100%

Estimated time:

Description

Please is possible redirect user to historic workflow task, when he click on task URL in email that is already solved?

Now when user click on task url that is already solved is only showed information about finished or non existing task:

For basic users is this really hard to understand.

For redirection will be probably required some special permission for read historic tasks. We will added this permission to all users that is in approving process.

Thank you :)

solved.png (9.65 KB) solved.png Ondřej Kopr, 03/27/2020 06:15 AM
historic_task_concept.png (98.2 KB) historic_task_concept.png Vít Švanda, 04/24/2020 12:06 PM
historic_task_request.png (114 KB) historic_task_request.png Vít Švanda, 04/24/2020 12:06 PM
deleted-concept.png (64.8 KB) deleted-concept.png Radek Tomiška, 05/12/2020 09:52 AM
wf-info-white-page.png (11.6 KB) wf-info-white-page.png Radek Tomiška, 05/12/2020 09:54 AM

History

#2 Updated by Ondřej Kopr 6 months ago

  • Target version set to 10.3.0

#3 Updated by Vít Švanda 5 months ago

  • Status changed from New to In Progress

#4 Updated by Vít Švanda 5 months ago

  • % Done changed from 0 to 40

#5 Updated by Vít Švanda 5 months ago

  • % Done changed from 40 to 60

#6 Updated by Vít Švanda 5 months ago

  • % Done changed from 60 to 70

#7 Updated by Vít Švanda 5 months ago

Implmented. I use more sophisticated solution on the end. If ID of a task doesn't exists, I try to find task in history of the WF. If exists then I try to create task looks like original. This task is returns as normal WF task. It means no redirection is needed now.

  • Detail of a historic tasks use same components on the FE. It means connected role-request or concept of role-request is show on task detail too.
  • On detail of the historic task is show specific information about time resolving that task and who it resolved.
  • Link to the whole process is show on the historic task detail.
  • DTO for history of workflow tasks was redesigned. Since this version is DTO WorkflowHistoricTaskInstanceDto extended by workflow task DTO WorkflowTaskInstanceDto. Some of a fields in WorkflowHistoricTaskInstanceDto were removed or renamed (candicateUsers, taskVariables)!
  • Workflow history task service was changed. Interface is same, but implementation of the toResource method was changed.
  • Detail of workflow process was redesigned too (UX improvments). New actions for show detail of a tasks (historic and unresolved) were added on this detail too.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/984c26faf39affcf093c4f0face2466216c6ad04
Tests: https://github.com/bcvsolutions/CzechIdMng/commit/eda1946694877a63b6aa9fe1d2ee091646e775fa


#8 Updated by Radek Tomiška 5 months ago

I did test and code review, this feature is awesome, when some link is in email, then detail is shown always.

I found some issues:
- historic task detail doesn't work (entity not found exception), when related entity is already deleted - e.g. when role concept is deleted (or whole identity).

- TaskHistoricInfo - white page is shown, when system information is shown

Some minor changes are in commit:
https://github.com/bcvsolutions/CzechIdMng/commit/80db5f7c86f0fd11720f7be6fe0d946b4f73c42d

#9 Updated by Vít Švanda 5 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • I added support for situation when identity or role-request/concept is deleted.
  • I fixed problem with showing system info.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/e0703843bcf698dd7dc885791c2bc52a3ccab498

#10 Updated by Radek Tomiška 5 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

It works, thx!

#11 Updated by Radek Tomiška 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top