Project

General

Profile

Actions

Task #213

closed

Password strength estimator

Added by Ondřej Kopr over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
-
Target version:
Start date:
11/24/2016
Due date:
% Done:

100%

Estimated time:
8.00 h
Owner:

Description

Actions #1

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

Please look on strength bar if is ok and do review. Thank you.

Actions #3

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I did review and test, it works nice. Some improvements:
  • add label with password streng to tooltip
  • create PasswordField component (new password + strength + password again) and use them in all forms with passwords (change, public change, create identity ...).

PS.: https://seethroughtrees.github.io/react-ux-password-field/

Actions #4

Updated by Ondřej Kopr over 7 years ago

After discussion with ZB, i have made some changes:
  • Add new component StrengthEstimator + readme,
  • add new component with two textfield and password estimator,
  • change password forms on others components.
Actions #5

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

Please do test and review for new changes. Thank you :-)

Actions #6

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 70
I did review and test, it works nice. Some issues from code review:
  • rename component to PasswordField (see above) and generalize AbstractFormComponent (it is form component) and respect their api (setValue, getValue ...) and remove redundant proptypes. getValue wiil return new passworn value.
  • in Password readme.md is readme about SelectBox :) and in StrengthEstimator too
  • rename component from StrengthEstimator to PasswordStrength
  • move same password validation into PasswordField component
  • padding bellow and above progressbar should be the same. Padding left should be zero.
  • remove strength label, when passord is not filled ... or show differrent label (maybe 'Password strength')
  • week password does not show progresbar now - the same requirement as in previous review
  • cross validation does not work now (e.g. when changing first field)
  • when new user is created, then password is lost
Actions #7

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 70 to 90
Fix:
  • Update password strength estimator validation, now is check score from generate password, CTRL+V and pre-fill from web browser,
  • fix readmes,
  • ix creating user, now is new password propagate to Create component correctly,
  • change AbstractContextComponent to AbstractFormComponent,
  • i added method getValue() and remove methods getNewPasswordAgain() and getNewPassword(),
  • fix cross validation beetween newPassword and newPasswordAgain,
  • in this task I also fix password change and immediately login. For now is password change only for idm, not all accounts. After change password we will receive message: "Vaše heslo bylo úspěšně změněno na všech Vašich účtech.", its not correct for now. After some discussion, I will fix it,
  • changes test on forms: Create identity, Edit identity, Public change password.
Actions #8

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions #9

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Its awesome, i just did little ui corrections, thx.

Actions

Also available in: Atom PDF