Project

General

Profile

Actions

Defect #2109

closed

Modal window with manual deactivation cannot be canceled

Added by Ondřej Kopr about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Start date:
03/09/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

When I want canceled modal windows with manual deactivation and I press No link the windows is still there.

Workaround: press escape :)

Affected version: >10.0.0


Files

manual.png (17.1 KB) manual.png Ondřej Kopr, 03/09/2020 12:36 PM
Actions #1

Updated by Radek Tomiška about 4 years ago

  • Target version set to 10.2.0

Workaround2: bulk action on table can be used. Issue is related to dashboard button only.

Actions #2

Updated by Radek Tomiška almost 4 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

This issue was a little tricky. The issue was related to confirm dialog is included directly in button content => Click into modal dialog calls click to button too, so modal was opened again (on the background) as result. I didn't find other way, than split rendering confirm dialog and button content (prevent event default and propagation doesn't help here), so new method ''renderConfirm'' was added to frontend component ''AbstractIdentityDashboardButton'' and has to be used for all dashboard buttons with confirm dialog instead rendering dialog together with button content.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/98bfd3af4c338e352c1cedadbaf91c0fd12da7c4

Could you provide me a feedbak, please?

Actions #3

Updated by Vít Švanda almost 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and test. Works well now. Thanks for this fix.

Actions #4

Updated by Radek Tomiška almost 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF