IdStory Identity Manager

I will add check for already deleted role, if this tasks are scheduled and running simultaneously.

Note: "Also, we don't think that automatic roles need to be processed by IdentityRoleExpirationTaskExecutor" - This is ok, automatic roles are removed this way (no other place exist - I've added better javadoc).

I improved LRT IdentityRoleExpirationTaskExecutor:
- task is statefull now and will continue on exception (queue is not supported, can be executed without rescheduling)
- asynchronous role requests are used now (the same as HrEndContractProcess) - requests are marked with owner entity to prevent it will be processed simultaneously (this solve simultaneously scheduled LRT and online user changes too)
- LRT localization added

I improved LRT IdentityContractExpirationTaskExecutor:
- asynchronous role requests are used now (the same as HrEndContractProcess) - requests are marked with owner entity to prevent it will be processed simultaneously (this solve simultaneous scheduled LRT and online user changes too)
- LRT localization added

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/16c03eda9621a57853e56016a695aabbffa74341

Could you provide me a feedback, please?

Note: One of IdentityContractExpirationTaskExecutor vs. HrEndContractProcess should be configured on project. IdentityContractExpirationTaskExecutor was created before HrEndContractProcess and checks dates only (project without HR can use this LRT).

I did review and test.

I found one problem with "IdentityRoleExpirationTaskExecutor":

• I have two expired identity-roles.
• I added throw runtime exception to the identity-role-delete-processor.
  

  if (true) {
              throw new RuntimeException("buum!!!!!!!!");
          }
  

• I expect that the LRT will completed two items with exception, but only first item was created and after that whole LRT ended with exception:

org.springframework.transaction.UnexpectedRollbackException: Transaction silently rolled back because it has been marked as rollback-only
    at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:755)
    at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:714)
    at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:152)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractSchedulableStatefulExecutor.processItemInternalNewTransaction(AbstractSchedulableStatefulExecutor.java:273)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractSchedulableStatefulExecutor.processCandidate(AbstractSchedulableStatefulExecutor.java:263)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractSchedulableStatefulExecutor.executeProcess(AbstractSchedulableStatefulExecutor.java:211)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractSchedulableStatefulExecutor.process(AbstractSchedulableStatefulExecutor.java:77)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractSchedulableStatefulExecutor.process(AbstractSchedulableStatefulExecutor.java:1)
    at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractLongRunningTaskExecutor.call(AbstractLongRunningTaskExecutor.java:212)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at org.springframework.security.concurrent.DelegatingSecurityContextRunnable.run(DelegatingSecurityContextRunnable.java:84)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)

I suppose you have disabled asynchronous processing (by configuration 'idm.sec.core.event.asynchronous.enabled=false').
I improved transactional LRT processing to cover this synchronous UC too (i't was not supported, but now it is :)).

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/f842cb56b2a16cd6eca0ea70baf3e041a53af7a4

Could you do a feedback again, please?

Note: When asynchronous processing is enabled, then roles are removed by asynchronous role request, you will see error in role request agenda only.

I did review and test. Works fine in synchronous mode now. Thanks for this.