Project

General

Profile

Actions
Copy link

Defect #2025

closed

SMS sent do not show in general notification

Added by Tomáš Doischer about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
10.5.0
Start date:
01/29/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
Citrine (7.3.0), Diamond (7.4.0), Emerald (7.5.0), Forsterite (7.6.0), Forsterite (7.6.1), Garnet (7.7.0), Garnet (7.8.0), Garnet (7.8.1), Garnet (7.8.2), Garnet (7.8.3), Garnet (7.8.4), Garnet (7.8.5), Hematite (8.0.0), Jade (8.1.0), Jade (8.1.2), Jade (8.1.3), Lapis (8.2.0), Jade (8.1.4), Malachite (9.0.0), Jade (8.1.6), Jade (8.1.7), Moonstone (9.1.0), Moonstone (9.1.1), Morganite (9.2.0), Morganite (9.2.1), Morganite (9.2.2), Onyx (9.3.0), Onyx (9.3.1), Opal (9.4.0-rc.1), Onyx (9.3.2), Onyx (9.3.3), Opal (9.4.0-rc.2), Onyx (9.3.4), Opal (9.4.0), Pyrite (9.5.0), Pyrite (9.5.1), Pyrite (9.5.2), Pyrite (9.5.3), Pyrite (9.5.4), Quartz (9.6.0), Quartz (9.6.1), Quartz (9.6.2), Quartz (9.6.3), Quartz (9.6.4), Quartz (9.6.5), Pyrite (9.5.1.2), Quartz (9.6.6), Rhyolite (9.7.0), Rhyolite (9.7.2), Rhyolite (9.7.3), Rhyolite (9.7.4), Rhyolite (9.7.5), Rhyolite (9.7.6), Rhyolite (9.7.7), Rhyolite (9.7.8), Rhyolite (9.7.9), Rhyolite (9.7.10), Rhyolite (9.7.11), Rhyolite (9.7.12), Rhyolite (9.7.13), 10.0.0, Rhyolite (9.7.14), 10.0.1, 10.1.0, Rhyolite (9.7.15), Rhyolite (9.7.16), 10.2.0, 10.0.2, 10.3.0, 10.3.1, 10.3.2, Rhyolite (9.7.17), 10.3.3, 10.4.0, 10.4.1
Owner:

Description

If you send an SMS message, then create a log in which you set sent time like this

smsLog.setSent(new DateTime());

the frontend shows the SMS as not sent in general notifications overview (see sms_notsent.png). However, in SMS notification, it is shown as sent (see sms_sent.png). This is not correct.

We also tried to set state to the log, it had no effect:

smsLog.setState(NotificationState.ALL);

Files

Download all files
sms_notsent.png (42.5 KB) sms_notsent.png Tomáš Doischer, 01/29/2020 10:22 AM
sms_sent.png (54.6 KB) sms_sent.png Tomáš Doischer, 01/29/2020 10:23 AM
Actions
Copy link
 #1

Updated by Radek Tomiška about 4 years ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #2

Updated by Radek Tomiška almost 4 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Radek Tomiška over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to 10.5.0
  • % Done changed from 0 to 90
  • Affected versions Citrine (7.3.0), Diamond (7.4.0), Emerald (7.5.0), Forsterite (7.6.0), Forsterite (7.6.1), Garnet (7.7.0), Garnet (7.8.0), Garnet (7.8.1), Garnet (7.8.2), Garnet (7.8.3), Garnet (7.8.4), Garnet (7.8.5), Hematite (8.0.0), Jade (8.1.0), Jade (8.1.2), Jade (8.1.3), Lapis (8.2.0), Jade (8.1.4), Malachite (9.0.0), Jade (8.1.6), Jade (8.1.7), Moonstone (9.1.0), Moonstone (9.1.1), Morganite (9.2.0), Morganite (9.2.1), Morganite (9.2.2), Onyx (9.3.0), Onyx (9.3.1), Opal (9.4.0-rc.1), Onyx (9.3.2), Onyx (9.3.3), Opal (9.4.0-rc.2), Onyx (9.3.4), Opal (9.4.0), Pyrite (9.5.0), Pyrite (9.5.1), Pyrite (9.5.2), Pyrite (9.5.3), Pyrite (9.5.4), Quartz (9.6.0), Quartz (9.6.1), Quartz (9.6.2), Quartz (9.6.3), Quartz (9.6.4), Quartz (9.6.5), Pyrite (9.5.1.2), Quartz (9.6.6), Rhyolite (9.7.0), Rhyolite (9.7.2), Rhyolite (9.7.3), Rhyolite (9.7.4), Rhyolite (9.7.5), Rhyolite (9.7.6), Rhyolite (9.7.7), Rhyolite (9.7.8), Rhyolite (9.7.9), Rhyolite (9.7.10), Rhyolite (9.7.11), Rhyolite (9.7.12), Rhyolite (9.7.13), 10.0.0, Rhyolite (9.7.14), 10.0.1, 10.1.0, Rhyolite (9.7.15), Rhyolite (9.7.16), 10.2.0, 10.0.2, 10.3.0, 10.3.1, 10.3.2, Rhyolite (9.7.17), 10.3.3, 10.4.0, 10.4.1 added

The issue was in product sms abstraction (AbstractSmsNotificationSender), where parent notification (=> and state) was not set properly.

Fixed in commit:
https://github.com/bcvsolutions/CzechIdMng/commit/d196c5c81b44c3b645aa42bd293336aa97f5da0d#diff-c162dbad301e90168d61284600896b71R103

Could you provide me a feedback, please?

Actions
Copy link
 #4

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška

I did review and test (this is hard for testing). Thanks for this fix.

Actions
Copy link
 #5

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF