Project

General

Profile

Actions

Task #2022

closed

Support of the delete bulk action for mapping

Added by Ondrej Husník almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondrej Husník
Category:
Systems
Target version:
Start date:
01/27/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Related issues

Related to IdStory Identity Manager - Task #2029: Refactor SysSystemMappingRepository find method to criteria.ClosedRadek Tomiška02/03/2020

Actions
Actions #1

Updated by Radek Tomiška almost 5 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Ondrej Husník almost 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 0 to 80

Hi Radek, please, find some time and energy to review my task. It seems to be working as I would expect.
Tests cover new delete bulk action, its prevalidation and SyncConfigFilter which was enriched by a new item (mappingId).

https://github.com/bcvsolutions/CzechIdMng/pull/77/commits/df0891710cdf91a2ab44a4f8c7e30ce5bd9ba3e1

Actions #3

Updated by Radek Tomiška almost 5 years ago

  • Category set to Systems
  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 80 to 100

I did test and code review, code is nice, i found and fix issue with filter usage:
https://github.com/bcvsolutions/CzechIdMng/commit/f3c7af86ec0c29eaecc8e26fcf7c1276b815f237

Note: Repository is used currently in find metfhod, will be refactored in #2029.

Actions #4

Updated by Radek Tomiška almost 5 years ago

  • Related to Task #2029: Refactor SysSystemMappingRepository find method to criteria. added
Actions #5

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF