Defect #2018
closed
When a new approval task is created by the WF, notification to the approving user is not sent
Added by Tomáš Doischer almost 5 years ago.
Updated almost 5 years ago.
Description
As the title says, the situation is that with the properies
idm.sec.core.wf.approval.manager.enabled = true
idm.sec.core.wf.notification.send = true
no notification is sent to the user for whom the task was created. The task exists and can be approved by the user but no notification is sent.
Files
What version of product do you use?
I tried this use-case (on 10.1.0):
- I set config property idm.sec.core.wf.notification.send=true.
- Then I created request for role with guarrantee.
- WF task was created and correct notification was created to.
Hello,
For your account kopr on CzechIdM system has been assigned a new approval task.
You can go to the task detail here: http://localhost:3000/#/task/cf9acca3-3eb6-11ea-9724-18568080446e
Regards BCV Solutions Ltd.
To clarify further, the approving user is the manager of the user, not the guarantee of the role (it works fine for them). So the use-case is different.
Ok, that is clear now. Sending notification on create new user-task is disabled in this activity (sendNotification).
I do not remember why this notification was turned off, but it was a requirement. But you can change this workflow :-).
Thank you, I will create a projspec version of the workflow then. :)
I found the origin of this code in #351 (commit 8c171432d). There is also some explanation of the principle how to send notifications, but no strict requirement to not send the notification for this particular task.
Since the workflow notifications are turned off by default thanks to the property idm.sec.core.wf.notification.send=false (which is also questionable in my opinion), there is really no other valid reason to turn it off again in the workflow.
We can compare it with the worfklow approveRoleByAuthorizer, which doesn't have "sendNotification" property defined and so it honors the global configuration.
- Priority changed from Normal to Low
- Target version set to Rhyolite (9.7.15)
I agree. Direct turning off sending notification only give me good sense if extra notification activity is implemented. I will remove this property.
- Target version changed from Rhyolite (9.7.15) to 10.2.0
- Assignee changed from Vít Švanda to Ondrej Husník
- Status changed from New to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
- % Done changed from 0 to 90
- Assignee changed from Vít Švanda to Radek Tomiška
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 90 to 100
I did test and code review, is works and code is nice, thx!
Also available in: Atom
PDF
