Project

General

Profile

Actions

Task #2016

closed

Use Idm cache manager in all places in application

Added by Radek Tomiška about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Category:
Cache
Target version:
Start date:
01/23/2020
Due date:
% Done:

100%

Estimated time:
16.00 h
Owner:

Description

Switch spring cache manager usage in all places in application to our cache manager.
Redesign cache usage for script agenda (DefaultGroovyScriptService#ScriptCache) - cache manager will be used too.
Rename cache names to fit puprose and add module field into our dto (native cache name can be splited, e.g. acc-provisioning-brake).


Related issues

Related to IdStory Identity Manager - Task #1976: Displaying cache usage and add possibility to clean it.ClosedPeter Štrunc12/04/2019

Actions
Actions #1

Updated by Radek Tomiška about 4 years ago

  • Related to Task #1976: Displaying cache usage and add possibility to clean it. added
Actions #2

Updated by Peter Štrunc about 4 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Vít Švanda about 4 years ago

  • Estimated time set to 16.00 h
Actions #4

Updated by Peter Štrunc about 4 years ago

I implemented util methods for cache manager and refactored cache manager usage in ConfigurationService and ScriptService.

Implementation is in pstrunc/2016-use-idm-cache-manager (branch is continuing on top of #1976)

TODO:
  • replace remaining occurences of Spring's CacheManager
  • check tests
Actions #5

Updated by Peter Štrunc about 4 years ago

  • % Done changed from 0 to 20
Actions #6

Updated by Peter Štrunc about 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Radek Tomiška
  • % Done changed from 20 to 70

Finished refactoring, added FE localized description and module name.

pushed to pstrunc/2016-use-idm-cache-manager

@tomiskar would you please review this task? Thanks

Actions #7

Updated by Radek Tomiška about 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Peter Štrunc

I did test and code review, cache manager is used in all places, thx!

I found just minor notes:
- BE: check please posibility to turn out th cache by configuration ('spring.cache.type=none') - application schould work without cache is used.
- BE: DefaultIdmCacheManager#toDto has warning in code, but ignore warning can be added only
- BE: Add spring bean name to DefaultIdmCacheManager, e.g. 'idmCacheManager' (can be used in script maybe in future by this name)
- BE: 'private' modifier can be added to field CacheControllerRestTest#cacheManager
- FE: newly created content on FE could name 'Caches' - it's list of caches (+fits to url)
- FE: check authorities in caches table is redundand (table#rendered) - content will not be rendered anyway (by routes definition).
- FE: 'Popis' is in english localization :).

Actions #8

Updated by Peter Štrunc about 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Radek Tomiška
  • % Done changed from 70 to 80

I fied all of the issues. IdM was really not working when cache was disabled, so i did some tweaks to make it work. All tests are green, when run with disabled cache except for those, which test cache functionality (obviously (:).

@tomiskar could you please look at the changes that i made? All is here https://github.com/bcvsolutions/CzechIdMng/pull/78 prepared to be merged. Thanks

Actions #9

Updated by Radek Tomiška about 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Peter Štrunc
  • % Done changed from 80 to 100

Thx, it's awesome!
I've merged it into develop.

Actions #10

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF