https://redmine.czechidm.com/https://redmine.czechidm.com/themes/purplemine2/favicon/favicon.ico?16339658642020-01-06T09:02:30ZIdStory Identity ManagerIdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=104192020-01-06T09:02:30ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Tomáš Doischer</i></li></ul><p>UC: When new contract D is not created, then no manager can edit this identity. This is the reason, why are evaluators for subordinates designed this way (contract state is ignored for subordinates).<br />Are you sure about this requirement?</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=104202020-01-06T09:55:47ZMarcel Poulmarcel.poul@bcvsolutions.eu
<ul><li><strong>Parent task</strong> deleted (<del><i>#1146</i></del>)</li></ul> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=104222020-01-06T09:56:27ZMarcel Poulmarcel.poul@bcvsolutions.eu
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/1146">Feature #1146</a>: Managers should change roles only for the contracts, for which they are managers</i> added</li></ul> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=111132020-03-13T13:28:27ZTomáš Doischer
<ul><li><strong>Assignee</strong> changed from <i>Tomáš Doischer</i> to <i>Radek Tomiška</i></li></ul><p>After the discussion on Slack, we arrived at the conclusion that we do need the manager of an ended contract to manully edit the user. So we would like it to work like this:</p>
A manager of a contract ended in the past
<ul>
<li><strong>CAN</strong> edit the identity</li>
<li><strong>CANNOT</strong> approve its role requests (no tasks should be created for the manager)</li>
</ul>
<p>Can you please implement this?</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=115562020-04-14T11:44:36ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Vladimír Kotýnek</i></li></ul><p>We didn't finish a discussion for this requirement, the last question remains open:<br />Do we need to the manager of an ended contract can edit the user?</p>
<p>Could you please confirm this requirement coming from your project only?</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=115572020-04-14T11:53:09ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/2204">Task #2204</a>: Authorization policies: Add permission to identity by contract (transitively)</i> added</li></ul> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=115842020-04-15T11:14:11ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>Vladimír Kotýnek</i> to <i>Radek Tomiška</i></li><li><strong>Target version</strong> set to <i>10.3.0</i></li></ul><p>We have consensus to implement this feature as original requirement says, so ended contract will not have a manager.</p>
Summary: A manager of a contract ended in the past
<ul>
<li><strong>CANNOT</strong> edit the identity</li>
<li><strong>CANNOT</strong> approve its role requests (no tasks should be created for the manager)</li>
</ul> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=116282020-04-17T10:05:17ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Vít Švanda</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul><p>It's implemented. Only valid or future valid contract can define managers and subordinates. Ended contract in the past cannot define managers or subordinates. On the other hand, contract state (e.g. manually disabled contract) still can define managers or subordinates - when contract is disabled by manager, then manager still can enable contract again.</p>
<p>Commit:<br /><a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/3246ea1ca2aed88a83eb08ef40d3279256de791c">https://github.com/bcvsolutions/CzechIdMng/commit/3246ea1ca2aed88a83eb08ef40d3279256de791c</a></p>
<p>Doc:<br /><a class="external" href="https://wiki.czechidm.com/devel/documentation/architecture/dev/filters">https://wiki.czechidm.com/devel/documentation/architecture/dev/filters</a></p>
<p>Could you provide me a feedback, please?</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=116352020-04-20T05:55:07ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>Vít Švanda</i> to <i>Radek Tomiška</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>50</i></li></ul><p>As we consulted on friday - we need all variants, because managers of invalid contract have to be provisioned.<br />So all changes above have to be refactored and new filter has to be created and used in requests and security.</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=116662020-04-21T10:42:57ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Vít Švanda</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>90</i></li></ul><p>New method ``IdmIdentityService#findAllManagers(UUID, UUID, Boolean)`` was added. Use this method to get managers of valid contracts (as approvers) in your custom scripts and workflows. This new method is used in product workflows. All product filters for find managers were updated and new optional parameter ``validContractManagers`` was added - change behavior in your custom (overriden) filters if needed. <br />Contract state (DISABLED) is ignored by this new filter - filter works just with contract dates.</p>
<p>Commit:<br /><a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/6ff3b859e7897514f9eb6433e1a28bb17a6efc7e">https://github.com/bcvsolutions/CzechIdMng/commit/6ff3b859e7897514f9eb6433e1a28bb17a6efc7e</a></p>
<p>Doc:<br /><a class="external" href="https://wiki.czechidm.com/devel/documentation/architecture/dev/filters">https://wiki.czechidm.com/devel/documentation/architecture/dev/filters</a></p>
<p>Could you provide me a feedback, please?</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=117412020-04-28T12:22:07ZVít Švanda
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Vít Švanda</i> to <i>Radek Tomiška</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>I did review and test. Manager cannot change roles for expired subordinate's contract now. If a contract is future valid, then assigned roles can be modified by manager.</p>
<p>Thnaks for this feature.</p> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=119652020-05-15T13:36:20ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul> IdStory Identity Manager - Task #2002: Managers of contracts ended in the past shouldn't be able to change roles for currect contracthttps://redmine.czechidm.com/issues/2002?journal_id=173082022-06-01T10:21:24ZTomáš Doischer
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/3129">Task #3129</a>: The EavCodeContractByManagerFilter returns subordinates from expired contracts</i> added</li></ul>