Task #2000
closed
Upgrade dependency on core to version 10.0.0
100%
Updated by Peter Štrunc about 5 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 70
I upgraded BE and FE dependencies and tested the functionality. I also fixed few sonar bugs and refactored some unnecessary imports. Code is in a separate branch on master 2.0.0-rc. I will find someone to do the review after the holidays.
Updated by Peter Štrunc almost 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Radek Tomiška
Hi @tomiskar, would you please review this task? Thanks
Updated by Radek Tomiška almost 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
- % Done changed from 70 to 90
I did code review for migration and install module into CzechIdM 10, module is available, awesome, thx!
Review notes:
- PasswordResetSwaggerConfig#exampleApi - duplicate bean name with example module - module cannot start - rename method to #pwdresetApi.
- product dependency should have provided scope
- module should have snapshot version in branch
- warnings is present in module (Assert.notNull without message etc.)
- backend sources should be moved into Realization/backend/idm-pwdreset folder (see archetype conventions https://github.com/bcvsolutions/idm-module-archetype#czechidm-module-archetype)
- html documetation is missing (see extras module pom as example)
- frontend dependencies (react-google-recaptcha, react-async-script) are already defined in product (app/package.json), could be removed from this module (=> reuse library from product).
Updated by Peter Štrunc almost 5 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
I fixed all mentioned issues. I had to do some magic with git branches.
There is 10.0.0 core version in both master and develop branches. If there is a need to finish unfinished version 1.7.0-snapshot, then there is a separate branch for that. Otherwise we will continue in develop with version 2.1.0.
Version is released. CLosing the ticket.