Defect #1992
closed
Missing decision buttons on virtual request detail
100%
Description
When virtual request detail is shown from other request detail - e.g. when the first request for the same account has to be approved, then decision buttons are not shown.
@affected version 10.0.0
Updated by Vít Švanda over 4 years ago
Hard task. The issue seemed very easy, but was hard to discovered trully cause and made fix.
Main problem was in dynamic key in routing.
React key in routes was generated from match.url from parent component (route). Good for agendas with tabs as Identity, Role ... .
But this doesn't works for details without parent component (AuditDetail, RoleRequestDetil, ...), because key will be not changed
if ID of entity changed in URL (parent match.url is doesn't contains ID of entity).
In phase where routes are created I don't have more informations for create more specific key. So I add full url to key if route doesn't have child routes. Looks like it's works now.
This problem was in many places for example on audit detail, role request detail, vs request detail.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/8b1a76b1b32a1607893e2ae81dd7b53725331568
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 0 to 90
I discovered minor problem in VS system.
Multivalued attribute was marked as changed even if value was not changed. I fixed this too.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/cadcae4a3032bc9135d704d9998d4281eb38cf1d
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
I did test and review, it works, thx!
Updated by Radek Tomiška about 4 years ago
- Status changed from Resolved to Closed