Task #1973
closed
Agenda for show all IdM services with methods
100%
Description
We can start with all services with ''@ScriptEnabled'' annotation - these services are usable in scripts.
How to get services is implemted here: ''IdmScriptAuthorityService.findServices'', but new method with some new filter dto can be added (e.g. ''EntityEventManager.find(filter)'').
''AvailableServiceDto'' can be reused and additional information can be added here (e.g field with available service methods). Dto should extend ''AbstractComponentDto''. This dto can be rendered in table on FE.
FE agenda - new tab in menu Setting > Modules > Services can be added with the same behavior as ''Filters'' tab - simple table without section can be used instead.
Filter for services will be available by ''text'' - ''like'' in service name.
Table will contain columns with service name (e.g. Filter type column), module, available methods.
Agenda will be available for all authenticated users (any additional authority is required).
Updated by Radek Tomiška about 5 years ago
- Description updated (diff)
- Category set to Scripts
Updated by Ondrej Husník about 5 years ago
- Status changed from New to In Progress
Updated by Ondrej Husník almost 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
- % Done changed from 0 to 90
Please provide me a code review and a feedback to this task with some constructive remarks if you found something that should be changed. Thx...
Updated by Radek Tomiška almost 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondrej Husník
I did test and code review, agenda works and code is nice too, awesome! I like parematers columns, is good idea.
I found just minor notes:
- AvailableMethodDto#returnType colud have Class type and cannonical name can be renderered in FE as tooltip (same as service)
- AvailableMethodDto#Equals hasn't format from our contributing conventions
- DefaultIdmScriptAuthorityService#findServices contains warnings in code (forgotten imports, Class) and has wrong formating (line #149)
- AvailableServiceController contains warnings in code (forgotten imports)
- AvailableServiceFilter constructor can define AvailableServiceDto type as dtoClass (filter controls this dto)
- AvailableServiceManager#getEntityType() - should return 'AvailableService'
- AvailableServiceService, AvailableServiceManager - jsdoc is missing
- service id (spring bean name) is most important than service name - can be switched on FE in table headers
Updated by Radek Tomiška almost 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
Updated by Radek Tomiška almost 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 90 to 100
I did test and code review, agenda works and code is nice, thx!
I did just small fixes:
- AvailableServiceControllerRestTest not pass - simple name in method argument was changed to canonical.
- I changed AvailableMethodDto#returnType to Class type (see note above).
- I fixed autority check on FE - new content with services is available for all authenticated users.
- I removed unused imports and warnings on BE and FE too :)
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/482b465af345e887485d858f83ab3efd295977d6
Merged into develop.
Updated by Radek Tomiška almost 5 years ago
- Status changed from Resolved to Closed