Project

General

Profile

Actions
Copy link

Task #1945

closed

LRT for importing user roles should assign the roles in one role request

Added by Alena Peterová over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Target version:
1.4.0
Start date:
11/18/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

ImportCSVUserContractRolesTaskExecutor creates a separate role request for every added role. It would be better to create one common role request for all roles for given user.

If the roles assign the same system and account on the system is not linked yet, then separate role requests may cause an exception:

Caused by: org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "ux_account_uid" 
  Detail: Key (uid, system_id)=(2094a048-78c5-4e31-95a2-ed66b85b0a49, \xe4433158a9bb404787c060e4e347457a) already exists.

Actions
Copy link
 #1

Updated by Tomáš Doischer over 4 years ago

  • Status changed from New to Needs feedback
  • % Done changed from 0 to 60

This is fixed, the code is in branch tdoischer/fix_import_roles. The tests run fine. Can you please review the code?

Actions
Copy link
 #2

Updated by Peter Štrunc over 4 years ago

  • Assignee changed from Alena Peterová to Peter Štrunc
  • Target version set to 1.4.0
Actions
Copy link
 #3

Updated by Peter Štrunc over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Tomáš Doischer

It looks good. You can merge it to develop.

Actions
Copy link
 #4

Updated by Tomáš Doischer over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 60 to 100

Thank you for the review, I merged it to develop.

Actions
Copy link

Also available in: Atom PDF