Project

General

Profile

Actions
Copy link

Task #1935

closed

Move LRT for removing workflow instances to product.

Added by Radek Tomiška about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Workflow
Target version:
Rhyolite (9.7.12)
Start date:
11/13/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

LRT was added into extras module - move implementation and test into core. Will be available under different module redundantly, but can be removed from extras module in the future release, after 9.7.12 dependency will be used).

Related issues

Related to extras - Task #1910: Move lrt for removing workflow instances. From a project to extrasClosedPeter Štrunc10/23/2019

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška about 5 years ago

  • Related to Task #1910: Move lrt for removing workflow instances. From a project to extras added
Actions
Copy link
 #2

Updated by Radek Tomiška about 5 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Radek Tomiška about 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

I reimplemented task for removing historic workflow instances in product:
- fixed: remove "master" workflow historic processes only (exception occured, when try remove subprocess)
- fixed: count initialization
- fixed: cancel running task is possible now
- added: task name and localization
- added: workflow definition select box
- added: new integration tests (all tests in extras are ignored)
- removed: redundant String.format usage in logger message.
- removed: assert from junit used in production code.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/17ccfcd15555050599c8de46df40360c8a7d79a0

Doc:
https://wiki.czechidm.com/devel/documentation/application_configuration/dev/scheduled_tasks/task-scheduler#deleteworkflowhistoricinstancetaskexecutor

Could you do a feedback, please?

Actions
Copy link
 #4

Updated by Radek Tomiška about 5 years ago

I've added new transaction support (for large data removal):
https://github.com/bcvsolutions/CzechIdMng/commit/0965ac7d3076456bd13b4a5fb06f9047fb4a043b

Actions
Copy link
 #5

Updated by Vít Švanda about 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did test and review. Works perfectly my workflow are gone. Thanks for that.

For the future I have only one suggestion for improvement: Name/IDs of deleted workflows are not logged now, but maybe would be this log useless.

Actions
Copy link
 #6

Updated by Radek Tomiška about 5 years ago

I agree, if ''AbstractSchedulableStatefulExecutor'' will be used, then even new transaction support can be used out of box (it's copied now). The only obstacle is native activiti query usage (~ by ''HistoricProcessInstanceQuery'') => we need to add some filters into our ''WorkflowHistoricProcessInstanceService''.

Actions
Copy link
 #7

Updated by Radek Tomiška about 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF