Project

General

Profile

Actions

Task #1933

closed

Create LRT for remove old notifications.

Added by Radek Tomiška over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
Start date:
11/13/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Create LRT for remove old notifications (all types) and related recipients.


Files

notifi-delete.png (45.2 KB) notifi-delete.png Vít Švanda, 11/22/2019 01:08 PM

Related issues

Related to IdStory Identity Manager - Feature #1671: Remove old notificationClosedRadek Tomiška05/21/2019

Actions
Actions #1

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

Notifications can be removed and long running task for remove sent notifications (''DeleteNotificationTaskExecutor'') older then 180 days is scheduled by default.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/5c90ce9fdf00ab1afe3d841adb4bff9a01cb7e0e

Doc:
https://wiki.czechidm.com/devel/documentation/application_configuration/dev/scheduled_tasks/task-scheduler#deletenotificationtaskexecutor
https://github.com/bcvsolutions/CzechIdMng/blob/hotfix-9.7.12/CHANGELOG.md#9712

Could you do a feedback, please?

Actions #2

Updated by Vít Švanda over 4 years ago

I did review and test. Works correctly.

I disovered only one strange behavior in count of deleted notifications. I deleted all notifications older then 360 days. Initial count in LRT was 270 but on the end were deleted only 244 notifications (without any exceptions). I do not see reason why is count different in this cause.
Second executing of the same LRT didn't delete any notifications.

Actions #3

Updated by Radek Tomiška over 4 years ago

The reason is, if the parent notification is deleted before children and children is deleted too with the parent (cascade). Then is counter not incremented (childen is not found in the next page). I'll try to add sort by parent to ensure child is deleted at first.

Actions #4

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

Child notifications are removed at first, now even count should fit, commit:
https://github.com/bcvsolutions/CzechIdMng/commit/54907e3a8d0d40730fa7bed07f3cd6093828b4b2

Could you do a feedback please, again :)

Actions #5

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I tested it. Start and end count match now, thanks for that.

Actions #6

Updated by Radek Tomiška over 4 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Radek Tomiška about 4 years ago

Actions

Also available in: Atom PDF