Task #1919
closed
LRT send notification that identity's last contract is ending
100%
Description
The notification is in this branch:
https://github.com/bcvsolutions/czechidm-extras/tree/tdoischer/18741-contract-end-notification
The documentation is here:
https://wiki.czechidm.com/tutorial/adm/notification_-_identity_s_last_contract_is_ending
Related issues
Updated by Tomáš Doischer over 4 years ago
- Status changed from New to Needs feedback
- Assignee set to Peter Štrunc
Updated by Peter Štrunc over 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Peter Štrunc to Tomáš Doischer
- % Done changed from 0 to 70
Notification looks great. Here are my notes:
- Why we skip excluded contracts in the getItemsToProcess? excluded contracts can also expire
- Theoretically you can miss some notiffications, if interval for notification sending is longer than validity of a contract (eg. send notification 2 weeks before end and contract's validity is from 1.1. to 5.1.)
- If notification is sent and then contracts validity is extended, next notification wont be sent. This may or may not be a problem, please check if it bothers anyone.
Updated by Tomáš Doischer over 4 years ago
- % Done changed from 70 to 90
Thank you for the code review! I fixed the first issue.
As for the second case, the notification will actually be sent, the check of validity is set so that the notification is sent if the contract end X days in the future or before that. I tested this with a user whose contract was valid from 5th November to 7th November. I configured the LRT to send the notification 14 days before the contract's end. It was sent anyway.
The third issue will be discussed, for now, I warn about this in the documentation.
Updated by Alena Peterová over 4 years ago
Updated by Radek Tomiška over 4 years ago
Localization support for LRT attributes can be used instead hard coded english texts directly in LRT.
Example:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/backend/core/core-impl/src/main/java/eu/bcvsolutions/idm/core/scheduler/task/impl/password/PasswordExpirationWarningTaskExecutor.java#L63
https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/frontend/czechidm-core/src/locales/en.json#L5314
Updated by Peter Štrunc over 4 years ago
- Related to Task #1962: Localize LRT parameters in LRT which sends notification before contracts end added
Updated by Peter Štrunc over 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
Localization will be solved in related task. Closing ticket