IdStory IdM modules » extras

I moved the projspec method and also script and tests.

Commit: https://github.com/bcvsolutions/czechidm-extras/commit/14e63fb937f90ac8f4fd73d4bd0793cda3767bc0 (branch: develop)

Please could you make a review? Thank you. I merged this directly into develop because we need this try on project, Thanks.

Ondřej Kopr wrote:

We founded some issues while we evaluate titles afters.

@klementm give me wrong info, there isn't issues in parsing and cutting logic, but only with missing title MBA. I made titles dictionary configurable.

Commit: https://github.com/bcvsolutions/czechidm-extras/commit/810d56db539616c59d5ce93b0cc6e6746a5e2216 (branch: develop)

Sorry for two commits, but the second contains configurable titles dictionary.

Documentation: https://wiki.czechidm.com/devel/documentation/modules_extras#get_titles_before_and_after

Please could you continue with feedback?

Cool feature! :)

Here are few minor notes:

Use StringUtils.isEmpty() instead of

if (value == null || value.isEmpty())

Instead of

String exits = dictonary.stream().filter(t -> t.trim().toLowerCase().equals(finalTitle)).findFirst()
                    .orElse(null);

use

String exits = dictonary.stream()
.map(String::trim)
.map(String::toLowerCase)
.filter(t -> t.equals(finalTitle))
.findFirst()
.orElse(null);

instead of

String exits = dictonary.stream().filter(t -> t.trim().toLowerCase().equals(finalTitle)).findFirst()
                    .orElse(null);

It is easier to read.

No other issues were found. You can push it to develop after resolving issues i mentioned above.

I fixed these above mentioned issues. Ticket can be closed now.