Project

General

Profile

Actions

Defect #1897

closed

Creating VS requests fails when name and code of VS attribute are not same

Added by Alena Peterová over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Virtual systems
Target version:
Start date:
10/08/2019
Due date:
% Done:

90%

Estimated time:
Affected versions:
Owner:

Description

@affected version > 7.4.0
When you set different code and name of VS attribute in the Form definition, then creating VS requests with the following error:

2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2) java.lang.IllegalArgumentException: Form attribute definition is required!
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at org.springframework.util.Assert.notNull(Assert.java:115)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at eu.bcvsolutions.idm.core.eav.service.impl.DefaultFormService.getValues(DefaultFormService.java:910)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at eu.bcvsolutions.idm.core.eav.service.impl.DefaultFormService.getValues(DefaultFormService.java:935)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at eu.bcvsolutions.idm.core.eav.service.impl.DefaultFormService.getValues(DefaultFormService.java:962)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at eu.bcvsolutions.idm.core.eav.service.impl.DefaultFormService$$FastClassBySpringCGLIB$$f7e12749.invoke(<generated>)
2019-10-08 18:27:59,028 INFO  [stdout] (event-task-executor-2)  at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)

This error is visible only in the catalina log; you can see only generic "Transaction rollback" in the provisioning archive.

The problem is in DefaultVsAccountService.getIcAttribute, which gets the name, but uses it as the code for formService.getValues.

Actions #1

Updated by Alena Peterová over 4 years ago

  • Subject changed from Creating VS requests fail when name and code of VS attribute are not same to Creating VS requests fails when name and code of VS attribute are not same
Actions #2

Updated by Vít Švanda over 4 years ago

  • Status changed from New to In Progress
  • Target version set to Rhyolite (9.7.9)

This was definitely wrong. Thanks for debugging and sorry for this bug.

I fixed it and I created test for it.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/291d52cf00d64a1a668cfebd925e41f5b6a69c3d

Actions #3

Updated by Vít Švanda over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 90
Actions #4

Updated by Vít Švanda over 4 years ago

  • Description updated (diff)
Actions #5

Updated by Radek Tomiška over 4 years ago

  • Description updated (diff)
  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda

I did test and review, it works, thx!

Actions #6

Updated by Radek Tomiška over 4 years ago

  • Description updated (diff)
Actions #7

Updated by Radek Tomiška over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF