Project

General

Profile

Actions

Task #1888

closed

Update ModelMapper

Added by Radek Tomiška over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Dto mapping
Target version:
Start date:
10/03/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Update ModelMapper to prevent the issue with map exception:
org.modelmapper.MappingException: ModelMapper mapping errors: Converter org.modelmapper.internal.converter.CollectionConverter@7214dbf8 failed to convert

More here: https://wiki.czechidm.com/9.7/documentation/known_issues#model_mapper

@affected version: all


Related issues

Related to IdStory Identity Manager - Task #1733: Update ModelMapperClosedVít Švanda06/25/2019

Actions
Related to IdStory Identity Manager - Defect #1898: Synchronization cannot be started because model mapper errorsClosedVít Švanda10/10/2019

Actions
Related to IdStory Identity Manager - Task #1906: ModelMapperChecker - test usage in LRTClosedRadek Tomiška10/17/2019

Actions
Related to IdStory Identity Manager - Defect #2271: Parent folder in catalogue cannot be removedClosedRadek Tomiška05/25/2020

Actions
Actions #1

Updated by Radek Tomiška over 4 years ago

Actions #2

Updated by Radek Tomiška over 4 years ago

  • Description updated (diff)
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

New ModelMapper library in version 2.3.5 is used (backported from version 10), this should help with known issue above.
I added simple check just for sure - when IdM starts, then all our registered services (and their registered model mapper converters) are called - this check fully covers agendas (services), which already contains some record (20 / 70 agenda after new IdM is installed) => it will be more effective on IdM, which is used longer time and restarted.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/3a2c80130fc1b507bc440def2ecc4a52a0805fc0

Could you do a feedback, please?

Actions #3

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review, thanks for this important update and awesome checker.

Actions #4

Updated by Radek Tomiška over 4 years ago

  • Status changed from Resolved to Closed
Actions #5

Updated by Radek Tomiška over 4 years ago

  • Related to Defect #1898: Synchronization cannot be started because model mapper errors added
Actions #6

Updated by Radek Tomiška over 4 years ago

  • Related to Task #1906: ModelMapperChecker - test usage in LRT added
Actions #7

Updated by Radek Tomiška almost 4 years ago

  • Related to Defect #2271: Parent folder in catalogue cannot be removed added
Actions

Also available in: Atom PDF