Feature #1887
closed
Dont set validTill for newly assigned role in IdentityAddRoleBulkAction
100%
Description
Bulk action IdentityAddRoleBulkAction fill validTill for newly created role concept. Valid till is filled by parameters from frontend, when this parameter missing is used validTill from contract.
Please is possible set null value when missing paramer valid till? Thank you.
There is code IdentityAddRoleBulkAction#136:
Before:
concept.setValidTill(validTill == null ? contract.getValidTill() : validTill);
After:
concept.setValidTill(validTill);
Thank you :)
Updated by Radek Tomiška about 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 0 to 90
I removed filling the value of 'validTill' automatically in bulk action and in synchronization (default role creation) too.
I added help blocks into bulk actions and update documentation.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/a220405357456977fa7284c8ed0eb9213727bf0b
Doc:
https://wiki.czechidm.com/tutorial/adm/identities_bulk_actions
Could you do a feedback, please?
Updated by Vít Švanda about 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
I did review and test. Works, thanks for that.
Updated by Radek Tomiška about 5 years ago
- Status changed from Resolved to Closed